Show changes in BSQ Supply over time #6106
Conversation
ghost
marked this pull request as ready for review
|
Hi @xyzmaker123 thanks for doing this, looks great. Can you post a screenshot of what it would look like when 'Month' is selected. Many thanks |
|
Hi @pazza83 - this is screenshot with 'Month' selected:
|
|
Thanks, looks great to me |
| .collect(Collectors.toList()); | ||
|
|
||
| items.forEach(i -> { | ||
| log.info("" + i.getKey()); |
There was a problem hiding this comment.
Is there a reason why you are logging this?
There was a problem hiding this comment.
Sorry, it's leftover - I'll remove it. Thanks for your vigilance.
There was a problem hiding this comment.
Please don't force-push when in review, just make another commit. Otherwise it is harder to update the branch and to look at the changes.
There was a problem hiding this comment.
OK - my mistake with leaving this logging code was so pitiful that I just wanted to clear it from git history :)
|
I don't t hink it is a good idea to also hardcode the values post-DAO as well. Doing it like this someone needs to update the values for each release (we have this issue already on the website, where it is stuck at cycle 29 - @m52go is there someone who is aware of doing this instead of you?). As total issued and total burned BSQ are already calculated for this graph it would be better IMO to use those than to hardcode the values. Also it would make the graph more correct post-DAO as ATM the total cycle values (not monthly) are shown, no matter if yearly, monthly or daily is selected.
|
|
Thanks for feedback @ripcurlx - I'll try to update pull request with dynamic calculation of BSQ supply. |
ghost
mentioned this pull request
|
@ripcurlx Review? 🙏 |
I'll have a look at it soon 😄 |
|
Rebased the PR and fixed two issues. |
Fixes #6100
Note: values are generated by this script and hardcoded in app.