Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 34 #1035

Closed
ghost opened this issue Mar 25, 2022 · 8 comments
Closed

For Cycle 34 #1035

ghost opened this issue Mar 25, 2022 · 8 comments
Assignees
@ripcurlx
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
Milestone
Cycle 34

Comments

@ghost
Copy link

ghost commented Mar 25, 2022 •
edited by ghost

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 992
  • USD requested: 1220
  • BSQ rate: 1.23 USD per BSQ
  • Previous compensation request (if applicable): For cycle 33 #998

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Fix NPE issue when edit fresh account dev 20 bisq-network/bisq#6058
Fix bug with text rendering on trade step info dev 20 bisq-network/bisq#6064
Editable account names dev 300 bisq-network/bisq#6014
Update currency filtering logic dev 200 bisq-network/bisq#6041
IBAN validation for SEPA account dev 250 bisq-network/bisq#6107
Separate transaction details in funds views dev 300 bisq-network/bisq#6110
Trigger price truncation of prompt text dev 30 bisq-network/bisq#6111
Update trigger price validation dev 100 bisq-network/bisq#6109

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Mar 25, 2022
@ghost ghost changed the title For cycle 34 For Cycle 34 Mar 25, 2022
@MwithM MwithM added this to the Cycle 34 milestone Mar 25, 2022
@MwithM MwithM added this to Review Complete in Compensation Request Board Mar 25, 2022
@MwithM MwithM moved this from Review Complete to In Review in Compensation Request Board Mar 25, 2022
@ripcurlx
Copy link
Contributor

@xyzmaker123 IMO compensation requested for Editable account names and IBAN validation for SEPA account is a bit high.

@ghost
Copy link
Author

ghost commented Mar 28, 2022

@ripcurlx OK - I downgraded them (400USD -> 300USD and 300 -> 250USD)

@ripcurlx
Copy link
Contributor

IBAN still says 300 instead of 250.

@ghost
Copy link
Author

ghost commented Mar 28, 2022

Sorry - I forgot to click "Update comment" - now it's updated.

@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request. Please submit your CR to the DAO for voting and post the transaction ID here afterwards. Thanks!

@ghost
Copy link
Author

ghost commented Mar 28, 2022

TXID: bb15654b3de059c809bd279acb55b48ca29848b6036cab5c160c7d70a962312b

@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Mar 28, 2022
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 7, 2022
@ghost
Copy link

ghost commented Apr 7, 2022

Issuance by Team:

team amount BSQ amount USD
dev 992.00 1220.00

Total Issuance: 992.00 BSQ (equivalent to: 1220.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Apr 7, 2022

Closed as accepted.

@MwithM MwithM closed this as completed Apr 7, 2022
Compensation Request Board automation moved this from Proposal Submitted to Closed Apr 7, 2022
@ghost ghost mentioned this issue May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
  
Closed
Milestone
Cycle 34
Development

No branches or pull requests
2 participants
@ripcurlx @MwithM