Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit BSQ swap offer #6116

Closed
wants to merge 2 commits into from
Closed

Edit BSQ swap offer #6116

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2022

Fixes #6075
Made it possible to edit price.

Screenshots:

bsq-swap-edit-offer


bsq-swap-edit-offer-2

@ghost ghost mentioned this pull request Mar 25, 2022
@ghost ghost marked this pull request as ready for review March 31, 2022 09:05
@ripcurlx
Copy link
Contributor

@xyzmaker123 As no fees are being paid for BSQ offers I think to edit a BSQ offer it causes less code changes if you just remove the old one and open a new create offer view with pre-populated fields similar as it is done when cloning an BSQ offer. But please wait with this until #6135 is merged as lot of code that you would touch is going to be changed.

@ghost
Copy link
Author

ghost commented Apr 23, 2022

@ripcurlx I rebased into master and resolved conflicts

just remove the old one and open a new create offer

I think it's not good approach:

  • it would be not possible to cancel edit offer
  • not consistent UI behavior in comparison with other offers edition

@ripcurlx
Copy link
Contributor

ripcurlx commented May 5, 2022

As I don't remember anymore if there was a reason (besides that there are no fees paid, so no loss when deleting an offer) I'd like to have @chimp1984 opinion on this as well.

@chimp1984
Copy link
Contributor

I do not remember any reason preventing that, but as you said as canceling an offer is without costs it was easier to cancel and re-create. I don't have time atm to review the changes. Its non trivial changes so should be reviewed with care.

@ghubstan
Copy link
Member

ghubstan commented May 5, 2022

I do recall @sqrrm saying he never intended to make swap offers editable because cancelling them is free.

If they become editable in UI, I will eventually need to make them editable in the API -- that is also a non-trivial change on both the CLI and server (daemon) side.

Repository owner closed this by deleting the head repository Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.8.3] Edit BSQ swap offer in offer book goes to nowhere
4 participants