Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxValidator: Fix crash on missing vin[0].prevout #7003

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Jan 15, 2024

The checkFeeAmountBTC method looks up the value field of the vin[0].prevout field without checking whether vin[0].prevout exists. When the field is missing JsonElement jsonVIn0Value = jsonVin0.getAsJsonObject("prevout").get("value"); (line 193) throws a NullPointerException.

Changes:

The `checkFeeAmountBTC` method looks up the `value` field of the
`vin[0].prevout` field without checking whether `vin[0].prevout` exists.
When the field is missing `JsonElement jsonVIn0Value =
jsonVin0.getAsJsonObject("prevout").get("value");` (line 193) throws a
NullPointerException.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit e9e62b9 into bisq-network:master Jan 25, 2024
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants