Add Elements Core Support and Provide Regtest Setup Tasks #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvasw
force-pushed
the
add_elementsd_wallet_support
branch
3 times, most recently
from
d0e556a
to
61aaa62
Compare
alvasw
force-pushed
the
add_elementsd_wallet_support
branch
15 times, most recently
from
1161183
to
9382c8b
Compare
Elements Core (Liquid Wallet) is built on top of Bitcoin Core, and many RPC calls are similar to Bitcoin Core. Bitcoin Core was implemented in PR #16. Changes: - Fluent Assertions (AssertJ) - Create interfaces for Transaction and Utxo - Generalize RpcClient for all future daemons and wallets - DaemonRpcCall interface to handle all daemon RPC calls - WalletRpcCall interface to handle all wallet RPC calls - New RPC calls: - getrawtransaction - gettxoutproof
Changes:
- Elements Core (elementsd) Process Manager
- ElementsRegtestSetup
- Implemented RPC calls:
- claimpegin
- createwallet
- finalizepsbt
- generatetoaddress
- getbalance
- L-BTC
- Liquid Assets
- getnewaddress
- getpeginaddress
- getrawtransaction
- gettxoutproof
- issueasset
- listtransactions
- listunspent
- listwallets
- loadwallet
- sendrawtransaction
- sendtoaddress
- L-BTC
- Liquid Assets
- signmessage
- stop
- unloadwallet
- verifymessage
- walletpassphrase
alvasw
force-pushed
the
add_elementsd_wallet_support
branch
3 times, most recently
from
2e55f91
to
98d4ac1
Compare
By providing --regtest-bitcoind or --regtest-elementsd as an argument, developers can tell Bisq to automatically load a Bitcoin Core/Elements Core regtest wallet. This will be used to automatically start Bisq 2 instances in the regtest setup.
alvasw
force-pushed
the
add_elementsd_wallet_support
branch
from
98d4ac1
to
bb93757
Compare
We can override the default data directory by providing --data-dir as an argument. This will be used in the regtest setup.
alvasw
force-pushed
the
add_elementsd_wallet_support
branch
from
bb93757
to
d31b4c4
Compare
The custom Gradle Tasks will help developers set up their Bitcoin Core/ Elements Core Regtest environment. These tasks set up an isolated Bitcoin Core/Elements Core regtest instance, create a wallet, and premine the initial regtest blocks/pegin BTC to L-BTC. The :desktop:runWithBitcoindRegtestWallet and :desktop:runWithElementsdRegtestWallet Gradle Tasks set up a regtest instance and automatically connect Bisq to it. See: docs/wallet-regtest-setup.md
alvasw
force-pushed
the
add_elementsd_wallet_support
branch
from
d31b4c4
to
6c99f7f
Compare
alvasw
changed the title
This was referenced Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements Core
See bisq-network/projects#64 for details.
Gradle: Regtest Setup Tasks
The custom Gradle Tasks will help developers set up their Bitcoin Core/
Elements Core Regtest environment. These tasks set up an isolated
Bitcoin Core/Elements Core regtest instance, create a wallet, and
premine the initial regtest blocks/pegin BTC to L-BTC.
The :desktop:runWithBitcoindRegtestWallet and
:desktop:runWithElementsdRegtestWallet Gradle Tasks set up a regtest
instance and automatically connect Bisq to it.
See: docs/wallet-regtest-setup.md