Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/2] Modularize Common Module (Java 9 Module) #99

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Feb 15, 2022

Add proper Java 9 Module support.

@alvasw alvasw changed the title Modularize Common Module (Java 9 Module) [1/2] Modularize Common Module (Java 9 Module) Feb 15, 2022
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide information whats the difference between the 2 Nullable packages?

@chimp1984 chimp1984 merged commit da06545 into bisq-network:main Feb 18, 2022
@alvasw
Copy link
Contributor Author

alvasw commented Feb 19, 2022

There is not really a difference between both packages. At first, the @Nullable and @NonNull/@NotNull annotations were part of multiple individual libraries, e.g., FindBugs. Sun, Google, JetBrains, and a couple others wanted to standardize it in JSR 305 (Annotations for Software Defect Detection) [1]. com.google.code.findbugs:jsr305 was the reference implementation [2].
However, the JSR's status has been dormant for many years. The library is usually loaded on the classpath, and Java 9 modules cannot require anything from the unnamed module. In the meantime, Findbugs was abandoned, and a project called SpotBugs [3] is recommended now.
I didn't want to add a dependency to SpotBugs because we never applied static analysis to look for bugs. We only use the annotations to give the IDE hints. For this purpose, JetBrain's annotation library is sufficient.

[1] https://jcp.org/en/jsr/detail?id=305
[2] https://mvnrepository.com/artifact/com.google.code.findbugs/jsr305
[3] https://spotbugs.github.io/

@alvasw alvasw deleted the modularize_common_module branch February 19, 2022 13:07
@chimp1984
Copy link
Contributor

Thanks for giving the background info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants