Tor/Onion code review changes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarguindzberg
changed the title
oscarguindzberg
force-pushed
the
tor-review
branch
from
c3fb9cf
to
b431458
Compare
oscarguindzberg
changed the title
There was a problem hiding this comment.
Is it possible to get rid of the dual addr / hostname fields in PeerAddress?
With OnionCatConverter.onionHostToInetAddress the onion address could be converted and then we only deal with addr in PeerAddress, no? I think hostname was also not part of the upstream branch, so to avoid to get too much changes added would make merge to upstream easier as well.
|
Just saw that hostname was also in the original PeerAddress code. Leave it to you to decide whats best. |
ManfredKarrer
approved these changes
Mar 23, 2019
This was referenced Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.