For March 2019

[oscarguindzberg]

Summary

Specify the total amount of BSQ you are requesting, and the BSQ address that amount should be paid to:

• BSQ requested: 12300
• BSQ address: B1LiYyuKpAZQHuyzRiFy8uBYNC71S8nEXQJ

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

Audits:

• Bisq's bitcoinj "addr" message support audit (2300 BSQ)
  • Audit report: Bisq's bitcoinj "addr" message support audit bitcoinj#28
  • Bugfix: Disable "add peers from addr message" custom bitcoinj feature when a … bisq#2591
  • Add link to this report on the source code: Add comment explaining "addr" message handling. bitcoinj#29
• bisq’s bitcoinj fee calculation changes audit (2200 BSQ)
  • Commit to audit: oscarguindzberg/bitcoinj@7dd1bfd
  • Fix: Don't use feePerKb as a fixed amount. bitcoinj#27
• Bisq’s bitcoinj tor support audit (2300 BSQ)
  • Audit report: Bisq’s bitcoinj tor/onion changes audit bitcoinj#25
  • Improvements: Tor/Onion code review changes bitcoinj#24
  • Created a couple of PR on bitcoinj upstream
    • PeerGroup.addAddress(): don't increase max connections if address alr… bitcoinj/bitcoinj#1741
    • Don't stop peer discovery if one peer discoverer throws an exception. bitcoinj/bitcoinj#1742
• TxBroadcaster audit (2000 BSQ)
  • Audit report: oscarguindzberg/bisq@82ef792
  • Improvements PR TxBroadcaster improvements bisq#2536

Other improvements:

• Compile bitcoinj with openjdk10 (700 BSQ)
  • Jdk10 bitcoinj#23
  • Upgrade bitcoinj version to the one built with jdk 10 bisq#2564
• Move clear blockstore feature to bitcoinj (300 BSQ)
  • Move clear blockstore feature to bitcoinj bitcoinj#22
  • Move clear blockstore feature to bitcoinj bisq#2563
• Investigate: Error at BitcoinJ deserializing message Error at BitcoinJ deserializing message  bisq#2557 (200 BSQ)
• Update testnet dns seeds Update testnet dns seeds bitcoinj#26 (100 BSQ)
• "Restore from seed"
  • Fix missing balance at restore from seed words Fix missing balance at restore from seed words bisq#2517 (100 BSQ)
    • Code review
  • Improve restore wallet from seed process Improve restore wallet from seed process bisq#2524 (400 BSQ)
    • I wrote the source code (oscarguindzberg/bisq@d307fa8)
    • Manfred created the PR.
    • I did code review and testing.
  • Stress on the label that Bisq will be shutdown after restore Stress on the label that Bisq will be shutdown after restore bisq#2530 (100 BSQ)
  • "Restore from seed" test on bisq. Some bugs were reported but I could not reproduce any bugs. (200 BSQ)
  • Retest bitcoinj upstream bug Wallet template restore from seed fails bitcoinj/bitcoinj#1704 because I was told it was solved. Report what is working and what is not. I had to update to java 11 because the wallet template bitcoinj subproject now requires that. It's important for us that have a benchmark wallet to know how restore from seed should work on bitcoinj. (200 BSQ)
  • Complete “Restore from seed using blockstore.clear() fix” upstream PR Clear the blockchain file (as opposed to delete it) in preparation for restore bitcoinj/bitcoinj#1702 (not merged upstream yet) (300 BSQ)

Research/exploratory tasks:

• Signet network research (400 BSQ)
  • It is a “stable testnet” with proof of authority.
  • Read email thread on bitcoin core mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016734.html
  • Start bitcoinj signet implementation https://github.com/oscarguindzberg/bitcoinj/tree/signet
• Rebroadcasting research (400 BSQ)
  • Discuss on bitcoinj mailing list https://groups.google.com/forum/#!topic/bitcoinj/lkK9N3NhoPY
  • Read thread about “reject” msg removal in bitcoin core mailing list https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016701.html

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

• Bisq’s bitcoinj connection handling changes audit
  • Bisq's bitcoinj connection handling changes audit bitcoinj#30

Roles performed

Provide links to your monthly report on any roles you are responsible for.

• BitcoinJ Maintainer: Bisq Bitcoinj Fork Maintainer roles#8 (comment) (100 BSQ)

[ripcurlx]

Closing as complete, see #243 (comment).