Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 21 #767

Closed
ghubstan opened this issue Jan 26, 2021 · 10 comments
Closed

For Cycle 21 #767

ghubstan opened this issue Jan 26, 2021 · 10 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghubstan
Copy link
Member

ghubstan commented Jan 26, 2021

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 20200
  • USD requested: 15150
  • BSQ rate: 0.75 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 20 #741

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Define new grpc bsq/btc balances protos dev 25 bisq-network/bisq#4793 (Cycle 20)
Add proto wrappers for sending bsq, btc or all balances dev 100 bisq-network/bisq#4794 (Cycle 20)
Define proto for api method 'getunusedbsqaddress' dev 25 bisq-network/bisq#4795 (Cycle 20)
Define proto for api method 'sendbsq' dev 25 bisq-network/bisq#4796 (Cycle 20)
Add proto fields to support trade fee currency choice dev 15 bisq-network/bisq#4797 (Cycle 20)
Implement and test api method 'getunusedbsqaddress' dev 500 bisq-network/bisq#4798 (Cycle 20)
Implement and test new getbalance(s) api methods dev 800 bisq-network/bisq#4799 (Cycle 20)
Stub out api method 'sendbsq' in core dev 350 bisq-network/bisq#4800 (Cycle 20)
Refactor desktop's BsqSendView 'sendbsq', share with api dev 150 bisq-network/bisq#4801 (Cycle 20)
Support paying trade fees in bsq or btc in api dev 650 bisq-network/bisq#4802 (Cycle 20)
Delete deprecated api wallet test, adjust api build/run doc dev 0 bisq-network/bisq#4803 (Cycle 20)
Refactor getbalance (bsq and/or btc) api dev 300 bisq-network/bisq#4808 (Cycle 20)
Add api method 'getpaymentmethods' dev 300 bisq-network/bisq#4818 (Cycle 20)
Add api method 'getpaymentacctform' dev 300 bisq-network/bisq#4819 (Cycle 20)
Replace existing api method 'createpaymentacct' impl dev 900 bisq-network/bisq#4821 (Cycle 20)
Fix api's createpaymentacct validation problems dev 0 bisq-network/bisq#4824 (Cycle 20)
Add more 'createpaymentacct' api tests dev 300 bisq-network/bisq#4828 (Cycle 20)
Set country on MoneyGram acct in gson type adapter dev 0 bisq-network/bisq#4834 (Cycle 20)
Update bats api test dev 0 bisq-network/bisq#4836 (Cycle 20)
Add tx fee rate api methods, requested changes in prior PRs dev 800 bisq-network/bisq#4858 (Cycle 20)
Refactor: move getDust(Transaction transaction) dev 25 bisq-network/bisq#4884 (Cycle 20)
Refactor BtcWalletService to let api override fee rates dev 200 bisq-network/bisq#4896 (Cycle 20)
Add optional txFeeRate parameter to api sendbsq dev 350 bisq-network/bisq#4900 (Cycle 20)
Add new api method 'sendbtc' and test dev 850 bisq-network/bisq#4922 (Cycle 20)
Support tx memo field for btc withdrawals from api dev 150 bisq-network/bisq#4925 (Cycle 20)
Use Bisq's UserThread.executor in gRPC server dev 0 bisq-network/bisq#4936 (Cycle 20)
Add new api method gettransaction dev 735 bisq-network/bisq#4948 (Cycle 20)
Refactor (improve) gRPC service error handling dev 50 bisq-network/bisq#4960 (Cycle 20)
Prevent excessive api calls dev 1100 bisq-network/bisq#4966 (Cycle 20)
Adjust lombok annotations to reduce build warnings dev 50 bisq-network/bisq#5021 merged
Tidy up apitest dev 0 bisq-network/bisq#5024 merged
Add new api methods 'getmyoffers', 'getmyoffer' dev 500 bisq-network/bisq#5056 merged
Fix log statement format dev 0 bisq-network/bisq#5059 merged
Fix two CLI option parsing bugs dev 0 bisq-network/bisq#5063 merged
Integrate new protection tools into api's offer & trade services dev 600 bisq-network/bisq#5065 merged
Stub out support for OpenOffer's triggerPrice in api dev 100 bisq-network/bisq#5076 merged
Use posix-style CLI opts, provide method help dev 400 bisq-network/bisq#5081 merged
Add core api method help docs dev 500 bisq-network/bisq#5084 merged
Add api trade simulation scripts dev 4000 bisq-network/bisq#5093 merged

Also participated in release testing and PR reviews.

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Define gRPC api call rate constraints dev --- bisq-network/bisq#5103 awaiting review / merge
Fix bash syntax inconsistencies dev 0 bisq-network/bisq#5116 awaiting review / merge
Git-ignore apitest dao-setup file dev 0 bisq-network/bisq#5125 awaiting review / merge
Do wallet checks before createoffer dev 0 bisq-network/bisq#5126 awaiting review / merge
Refactor trading simulation scripts dev --- bisq-network/bisq#5128 awaiting review / merge
Add rolling offer simulation script dev --- bisq-network/bisq#5129 awaiting review / merge
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Jan 26, 2021
@ghubstan ghubstan added this to In progress in Ship Bisq Daemon and API Jan 26, 2021
@MwithM MwithM added this to In Review in Compensation Request Board Jan 27, 2021
@MwithM
Copy link
Contributor

MwithM commented Jan 27, 2021

Please mark at the notes the tasks that were already approved by team leader at at Cycle 20. https://github.com/orgs/bisq-network/teams/dao/discussions/21

@MwithM MwithM added this to the Cycle 21 milestone Jan 27, 2021
@ripcurlx
Copy link
Contributor

@sqrrm Could you please jump in on reviewing this items? Thanks!

@sqrrm
Copy link
Member

sqrrm commented Jan 29, 2021

I approve of this CR.

@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Jan 29, 2021
@ghubstan
Copy link
Member Author

ghubstan commented Feb 2, 2021

@ripcurlx I think I need to get a 'paste your proposal tx' msg from you.
I think the cycle phase for doing this has not arrived, but I want to ping you just to make sure I get this included in cycle 21.

@MwithM
Copy link
Contributor

MwithM commented Feb 2, 2021

@ghubstan I'm quite sure that you can submit your proposal after @sqrrm approved the request after ripcurlx asked him to review it.
The proposal phase ends in about 24h you should submit it before then, and copy the TXID in a comment.

@ghubstan
Copy link
Member Author

ghubstan commented Feb 2, 2021

0f8bacca45221ca2b8ac2a77ff82cfbdbed46e8939f5b147342581172b0b3e98

@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 3, 2021

@ripcurlx I think I need to get a 'paste your proposal tx' msg from you.
I think the cycle phase for doing this has not arrived, but I want to ping you just to make sure I get this included in cycle 21.

Sorry about that. Yes, I approve this compensation request as team lead for dev.

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Feb 3, 2021
@ghubstan
Copy link
Member Author

ghubstan commented Feb 3, 2021

Np, 0f8bacca45221ca2b8ac2a77ff82cfbdbed46e8939f5b147342581172b0b3e98 again.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Feb 10, 2021
@ghost
Copy link

ghost commented Feb 10, 2021

Issuance by Team:

team amount BSQ amount USD
dev 20200.00 15150.00

Total Issuance: 20200.00 BSQ (equivalent to: 15150.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Feb 10, 2021

Closed as accepted.

@MwithM MwithM closed this as completed Feb 10, 2021
Compensation Request Board automation moved this from Proposal Submitted to Closed Feb 10, 2021
Ship Bisq Daemon and API automation moved this from In progress to Done Feb 10, 2021
@ghubstan ghubstan mentioned this issue Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Development

No branches or pull requests

4 participants