Add Monero wallet features to Bisq

[ManfredKarrer]

As repeatedly requested by the Monero community that Bisq add XMR support as base currnecy and to reflect the fact that Monero is by far the most traded currency (> 90% of volume) I would suggest as first step the integration of a Monero wallet via RPC to monerod.

The user need to run monerod and Bisq would connect vai RPC to the deamon. A basic Monero wallet UI for satisfying the needs for a Bisq Monero trade should be added as well.
Maybe even better would be to automate a trade by triggering the Monero wallet transfer in case of a XMR seller or check if XMR was received in case of the XMR buyer.

[ManfredKarrer]

Seems that proposal gets some love ;-). Only missing a dev to harvest that love ;-)

[scottAnselmo]

As a Monero community member created a Reddit post and pinged the monero-dev IRC channel. If it isn't mentioned in the next dev meeting, I'll mention it in the opens; this is something I'd very much like to see.

[clearwater-trust]

https://github.com/ExodusMovement/mymonero-core-js

[ManfredKarrer]

See https://www.reddit.com/r/bisq/comments/ae7z72/tighther_monero_integration_in_bisq_a_monero_devs/

[justpaulgmx]

I agree, this is a critical and time sensitive item and the talent and time to do it is very rare. I can do some recruitment on my end.

[yoshimo]

I am sure that would be something people would support with a few Monero in funding if you can find someone willing to do it.

[battleofwizards]

What would be the ideal end vision for different cryptocurrency wallets integrated into Bisq?

Say in 10 years? Some possible options:

• Bitcoin + BSQ only
• Bitcoin + BSQ + Monero only
• All cryptocurrencies heavily traded on Bisq
• All fundamentally relevant cryptocurrencies
• All popular cryptocurrencies (lots of them...)

Thought experiment: say in 2 years Monero's 98% volume dominance collapsed to 1% (maybe a reverse turbo xmr.to showed up or sth). Do we maintain or remove the integration? Do we integrate whatever is then popular? How many wallets can we integrate and maintain before collapsing under own mass?

I don't have the answers - just food for thought.

[niyid]

Hi @ManfredKarrer

I had to revisit this proposal because it is being handled as part of #110.

I have (mostly) completed the Monero Wallet and its functionalities and now I am looking at the integration into trades (buying and selling of XMR).

The question is: will it be best to implement similar to the current design for Bitcoin where BTC is the base currency allowing the exchange of anything for XMR and XMR for anything (in which case XMR is the base currency for such trades); or should it just plug into the current design as an enhancement to the accounts architecture - simply adding the wallet as one of the available XMR accounts?

Regards.

[chimp1984]

XMR as base curreny is not possible without monumental efforts. I don't have time to follow your efforts here. Please get in touch with other Bisq devs and maybe make a presentaion of what you have and whats your plans to avoid misalignments.

[remon-nashid]

... I don't have time to follow your efforts here. Please get in touch with other Bisq devs and maybe make a presentaion of what you have and whats your plans to avoid misalignments.

Way to encourage Bisq contributors! You could've at least answered his/her simple question.

[niyid]

XMR as base curreny is not possible without monumental efforts. I don't have time to follow your efforts here. Please get in touch with other Bisq devs and maybe make a presentaion of what you have and whats your plans to avoid misalignments.

Thanks for your response. As it will take a monumental effort to go with an XMR base currency design, I will simply concentrate on the latter: plugging the XMR Wallet functionality into the existing Altcoin Accounts design as currently exists for trading.

@remon-nashid Thanks. He's a he. 😁
Regards.

[mpolavieja]

@niyid, I understand that your assigned to this project. Could we close this issue as approved and continue at issue #110?

[erciccione]

I agree this should be closed as approved.

[niyid]

@mpolavieja Yes indeed. Regards.

…

On Tue, Sep 17, 2019, 10:13 mpolavieja ***@***.***> wrote: @niyid <https://github.com/niyid>, I understand that your assigned to this project. Could we close this issue as approved and continue at issue #110 <#110>? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51?email_source=notifications&email_token=AE2MWR4WIUWQ7JJ2YC26GE3QKCNULA5CNFSM4F6QDOSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD633ZHY#issuecomment-532135071>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE2MWR5MKLNNQ2IH7MXV2KLQKCNULANCNFSM4F6QDOSA> .

[mpolavieja]

This proposal has been approved. For ongoing discussion refer to issue #110

[chimp1984]

For reference about feasibility of XMR as base currency from Monero dev rbrunner: https://rbrunner7.github.io/bisq.html