Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests Disappear when Prayed #26

Closed
danieljsummers opened this issue Sep 2, 2019 · 3 comments
Closed

Requests Disappear when Prayed #26

danieljsummers opened this issue Sep 2, 2019 · 3 comments
Assignees
@danieljsummers
Labels
bug

Comments

@danieljsummers
Copy link
Collaborator

On different devices, requests are disappearing rather than going to the bottom of the journal. I suspect this is due to time differences between the device and the server. Modify the web app to send the timestamp along with actions such as "Prayed" or "Updated", and use that instead of taking the value of "now" from the server.
@danieljsummers danieljsummers self-assigned this Sep 2, 2019
@danieljsummers
Copy link
Collaborator Author

this will be part of v2

@danieljsummers
Copy link
Collaborator Author

The more I thought about this, taking the client's incorrect time is the wrong solution. Rather than using the time from the client, zero out showAfter server-side instead for immediately recurring requests. This will move them to the bottom of the journal (sorted by asOf desc) and will not trigger the issues that setting it to the current date/time does. Non-immediate recurrence requests should disappear until their recurrence time comes back around, and still will, because their showAfter will be computed based on their recurrence.

danieljsummers added a commit that referenced this issue Sep 2, 2019
@danieljsummers
Set showAfter to 0 for immediately recurring requests (#26)
0ea4249
danieljsummers added a commit that referenced this issue Sep 3, 2019
@danieljsummers
myPrayerJournal v2 (#27)
fa78e86 
App changes:
* Move to Vue Material for UI components
* Convert request cards to true material design cards, separating the "pray" button from the others and improved highlighting of the current request
* Centralize Auth0 integration in one place; modify the Vuex store to rely on it entirely, and add a Vue mixin to make it accessible by any component

API changes:
* Change backing data store to RavenDB
* Evolve domain models (using F# discriminated unions, and JSON converters for storage) to make invalid states unrepresentable
* Incorporate the FunctionalCuid library
* Create a functional pipeline for app configuration instead of chaining `IWebHostBuilder` calls

Bug fixes:
* Set showAfter to 0 for immediately recurring requests (#26)
@danieljsummers
Copy link
Collaborator Author

Fixed in v2

@danieljsummers danieljsummers mentioned this issue Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieljsummers danieljsummers

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danieljsummers