Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory name collision between YOEO and TORSO-21 #61

Closed
jaagut opened this issue Nov 16, 2022 · 4 comments · Fixed by #60 or #65
Closed

Directory name collision between YOEO and TORSO-21 #61

jaagut opened this issue Nov 16, 2022 · 4 comments · Fixed by #60 or #65
Labels
help wanted Extra attention is needed

Comments

@jaagut
Copy link
Member

jaagut commented Nov 16, 2022

  • YOEO expects segmentation mask images inside a directory called segmentations (see here).
  • TORSO-21 provides segmentation mask images inside a directory called segmentaions
    • Masks are human-seeable: colors are distinct (0, 127, 255, ...)

Expected behavior

The directory names should not collide, i.e., should not be identical.

Current behavior

Converted masks are in yoeo_masks directory.
User has to rename directory and resolve name conflict manually.

Possible Solution

  • YOEO's dataloader reads from a differently called directory like yoeo_masks
  • ...
@Flova
Copy link
Member

Flova commented Nov 17, 2022

Honestly, I think this resulted in YOEO using the original TORSO annotations...
See line https://github.com/bit-bots/YOEO/blob/main/yoeo/utils/datasets.py#L125

@Flova
Copy link
Member

Flova commented Nov 17, 2022

But I think that YOEO should not use the TORSO annotations directly.

@jaagut
Copy link
Member Author

jaagut commented Nov 18, 2022

In person conversation with @Flova:

  • The convert script should put it's output (0,1,2, ...) to yoeo_segmentations, where the dataloader will be reading from.
  • We should not map the TORSO-21 segmentations (0, 127, 255, ...) to YOEO format inside the dataloader (as mentioned in Directory name collision between YOEO and TORSO-21 #61 (comment)). By this, YOEO directly depends on TORSO-21, which should not be the case, and we have implemented the conversion in two times, circumventing the script.

@jaagut
Copy link
Member Author

jaagut commented Nov 23, 2022

Partially resolved by: #60

@jaagut jaagut reopened this Nov 30, 2022
@Flova Flova mentioned this issue Dec 6, 2022
4 tasks
@jaagut jaagut closed this as completed in #65 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
2 participants