Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more proper approach for naming & designing of IAppEvent interface #119

Closed
msynk opened this issue Sep 2, 2018 · 1 comment
Closed

Use a more proper approach for naming & designing of IAppEvent interface #119

msynk opened this issue Sep 2, 2018 · 1 comment
Assignees
@ysmoradi

Comments

@msynk
Copy link
Member

msynk commented Sep 2, 2018 •
edited
Loading

I think its better to change IAppEvents interface name or design in a more appropriate method.
You could change its name to IApplicationLifecycleEvents or IAppLifecycleEvents. or split it to two separate interface named IAppStartEvents and IAppEndEvents, or IAppStartupEvents and IAppShutdownEvents.
@ysmoradi
Copy link
Member

I appreciate this. I'd like to use IAppLifecycleEvents

@ysmoradi ysmoradi self-assigned this Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ysmoradi ysmoradi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ysmoradi @msynk