Remove "tools.syncfs()"

[buhtz]

backintime/common/tools.py

Lines 1539 to 1547 in d33f35e

	def syncfs():
	"""
	Sync any data buffered in memory to disk.
	Returns:
	bool: ``True`` if successful
	"""
	if checkCommand('sync'):
	return(Execute(['sync']).run() == 0)

I vote to remove that function because there is no appropriated use case for it. It simply execute sync on the shell to make sure the file system is "synced" (flushed).

Checking via grep it seems to be used only in tools.shutdown():

backintime/common/tools.py

Lines 2223 to 2241 in d33f35e

	def shutdown(self):
	"""
	Run 'shutdown -h now' if we are root or
	call the dbus proxy to start the shutdown.
	"""
	if not self.activate_shutdown:
	return(False)
	if self.is_root:
	syncfs()
	self.started = True
	proc = subprocess.Popen(['shutdown', '-h', 'now'])
	proc.communicate()
	return proc.returncode
	if self.proxy is None:
	return(False)
	else:
	syncfs()
	self.started = True
	return(self.proxy(*self.args))

The shutdown command on shell itself is designed to make sure the shutdown is clean and healthy. This includes a synced/valid state of the file system.

Don't forget to remove the unit tests, too.