refactor!: Remove tools.syncfs() #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added
the
PR: Merge after creative-break
dw4102
pushed a commit
to dw4102/backintime
that referenced
this pull request
May 4, 2024
Was used in shutdown() only. Shutodwn cause an unmount which itself cause synfs on OS level. No need for BIT to do it explicit. Behavior of BIT do not change. Additionally minor PEP8 improvements. Close bit-team#1685 Finish rpmbuild & specfile creation feat: RPM package building support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the function
tools.syncfs()and its unit test. It was used inshutdown()only. Shutodwn cause an unmount which itself cause synfs on OS level. No need for BIT to do it explict. Additionally minor PEP8 improvements.No changelog because the modification do not modify, break or remove existing behavior in BIT.
Close #1685