Fixes #1592, #1580, #836, #1350: "qt5_probing.py" hangs; Cannot launch … BiT (root) on Wayland #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run as root and no user is logged into a desktop environment
…robing.py" hangs; Cannot launch BiT (root) on Wayland - "qt5_probing.py" hangs when BiT is run as root and no user is logged into a desktop environment - BiT (root) starter script does not set Qt5 wayland-egl plugin anymore but uses the default (like BiT userland) - Improve logging (all sub process do now use the log context "backintime" too for easy journalctl grepping
…robing.py" hangs; Cannot launch BiT (root) on Wayland - "qt5_probing.py" hangs when BiT is run as root and no user is logged into a desktop environment - BiT (root) starter script does not set Qt5 wayland-egl plugin anymore but uses the default (like BiT userland) - Improve logging (all sub processes do now use the log context "backintime" too for easy journalctl grepping
buhtz
approved these changes
Jan 4, 2024
common/logger.py
Outdated
Comment on lines
40
to
47
| """ | ||
| Initializes the logger | ||
|
|
||
| Esp. sets the app name for the log output so that the system log | ||
| can be queried with with grep. | ||
|
|
||
| Don't forget to call it in each sub process that uses logging. | ||
| """ |
There was a problem hiding this comment.
I would like to rephrase that docstring somehow to make clear which log system is used and that it is not the regular logging module of python.
"""
Initializes the logger system using syslog.
Esp. sets the app name as identifier for the log entries in the syslog.
Attention: Call it in each sub process that uses logging.
"""
By the way. You don't need grep here. Syslog is a special case when it comes to journalctl which usually works with unit names. You need to give it the SYSLOG_IDENTIFIER we used here.
journalctl -t backintime
# or
journalctl SYSLOG_IDENTIFIER=backintime
There was a problem hiding this comment.
Cool side note, I didn't know that (and have never read the man pages of journalctl completely 😉
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG was updated