fix: Open symlinked folders in fileview

[buhtz]

Symlink folders in fileview now can be opened via double click in all circumstances.

I have to say that I am not sure about that solution or its implications. The related code is to complex (for me) to be sure.
But on my tests it worked.

Close #1476

[buhtz]

I don't feel well merging this without proper review. So I am waiting. But there is no hurry.

[aryoda]

I don't feel well merging this without proper review. So I am waiting. But there is no hurry.

Sorry, I did review this (but without actually running the code) and the only thing I have found is the question about a better name for the canOpenPath function (something like eg. IsExistingPathInsideSnapshotFolder - or shorter).

Just propose a better name (or even decide to leave it as it is for now since there is a function doc string):

backintime/common/snapshots.py

Lines 2623 to 2632 in ed282ad

	def canOpenPath(self, path):
	"""
	``True`` if path is a file inside this snapshot
	Args:
	path (str): path from local filesystem (no snapshot path)
	Returns:
	bool: ``True`` if file exists
	"""

Is there something special I should test (eg. risky code change)?

[emtiu]

I won't have a chance for some time, but I'll be happy to test this in a VM.

[buhtz]

the only thing I have found is the question about a better name for the canOpenPath function (something like eg. IsExistingPathInsideSnapshotFolder - or shorter).

I renamed now and just used your proposal.

Is there something special I should test (eg. risky code change)?

😁 It is primarily an irrational sensation. I lack a thorough understanding of that section of the code, which hinders me from realistically contemplating its implications. It's nothing serious, just a minor challenge.

No meed to merge it soon. It can wait some weeks if Michael want to test it.