Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now setColor will set background color of label. #9

Closed
wants to merge 1 commit into from

Conversation

DonKarlssonSan
Copy link

When calling setColor(), the background color of the label is not updated.

  1. Add a color picker
  2. Call setColor from your code
    -> now the color number on qs_label, will update but not the background color of qs_color_label.

Repro on CodePen: http://codepen.io/DonKarlssonSan/pen/ALqpQZ

I'm not sure whether this is the most elegant fix but it seems to work. =)

@bit101
Copy link
Owner

bit101 commented Nov 5, 2016

Thanks! I just fixed that in the "next" branch, which will be merged to master shortly.

@bit101 bit101 closed this Nov 5, 2016
@domisolsi
Copy link

Can't get quicksetting.js fixed in the master repository(?)
setColor() doesn't update the label yet...
Thanks for your reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants