Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Disco to return basic types #47

Closed
shochdoerfer opened this issue Aug 12, 2016 · 0 comments
Closed

Allow Disco to return basic types #47

shochdoerfer opened this issue Aug 12, 2016 · 0 comments
Milestone

Comments

@shochdoerfer
Copy link
Member

Due to the changes #40 it is no longer possible to return primitive types. As pointed out by @settermjd it might make sense to return primitives sometimes.

This requires a few changes:

  • it is needed to check if type defined in @return is a primitive type. If it is ommit the type check
  • Lazy Beans need to check the type and do not use proxymanager for primitives

It make sense to wait for the ProxyManager 2 / PHP 7.x migration (see #46) before tackling this problem as with the built-in return typehint support it might be easier to handle the type detection.

@shochdoerfer shochdoerfer added this to the 0.5.0 milestone Aug 14, 2016
shochdoerfer added a commit that referenced this issue Aug 16, 2016
Fixed #47: Primitive types can be returned from the bean methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant