Remove BeanFactoryPostProcessor

Upgrade.md

@@ -38,6 +38,13 @@ the `@Parameter` collection. The new syntax looks like this:
      */
 ```
 
+## BC BREAK: Removal of BeanFactoryPostProcessor
+
+Injecting a container into a bean (service) is considered a bad practice,
+thus the BeanFactoryPostProcessor implementation is removed. The general
+post processor logic is still in place, a custom BeanFactoryPostProcessor
+implementation can still be used.
+
 # Upgrade to Disco 0.5.0
 
 ## BC BREAK: Rasing minimum PHP version to 7.0

docs/advanced/bean-post-processor.md

@@ -58,11 +58,3 @@ Disco will call every post processor for every new bean instance created.
 In case of a singleton bean the call for each post processor will happen once,
 in case of a lazy bean the call will happen when the "real" instance gets
 created. Disco will manage this all for you.
-
-# BeanFactoryPostProcessor
-
-Disco comes with one post processor implementation out-of-the-box:
-`\bitExpert\Disco\BeanFactoryPostProcessor`. This post processor will only
-run for classes implementing the `\bitExpert\Disco\BeanFactoryAware`
-interface. As the name implies it will inject the current BeanFactory
-instance into the created bean instance.

src/bitExpert/Disco/Proxy/Configuration/MethodGenerator/Constructor.php

@@ -59,8 +59,6 @@ public function __construct(
         $body .= '$this->' . $sessionBeansProperty->getName() . ' = $' . $beanFactoryConfigurationParameter->getName() .
             '->getSessionBeanStore();' . PHP_EOL;
         $body .= '// register {@link \\bitExpert\\Disco\\BeanPostProcessor} instances' . PHP_EOL;
-        $body .= '$this->' . $beanPostProcessorsProperty->getName() .
-            '[] = new \bitExpert\Disco\BeanFactoryPostProcessor();' . PHP_EOL;
         foreach ($beanPostProcessorMethodNames as $methodName) {
             $body .= '$this->' . $beanPostProcessorsProperty->getName() . '[] = $this->' . $methodName . '(); ';
             $body .= PHP_EOL;

tests/bitExpert/Disco/AnnotationBeanFactoryUnitTest.php

@@ -23,7 +23,6 @@
 use bitExpert\Disco\Config\BeanConfigurationWithPrimitives;
 use bitExpert\Disco\Config\BeanConfigurationWithProtectedMethod;
 use bitExpert\Disco\Config\WrongReturnTypeConfiguration;
-use bitExpert\Disco\Helper\BeanFactoryAwareService;
 use bitExpert\Disco\Helper\MasterService;
 use bitExpert\Disco\Helper\SampleService;
 use bitExpert\Disco\Helper\SampleServiceInterface;
@@ -251,19 +250,6 @@ public function postProcessorHookRunsAfterLazyBeanCreation()
         self::assertEquals('postProcessed', $bean->test);
     }
 
-    /**
-     * @test
-     */
-    public function beanFactoryPostProcessorHookRuns()
-    {
-        $this->beanFactory = new AnnotationBeanFactory(BeanConfigurationWithPostProcessor::class);
-        BeanFactoryRegistry::register($this->beanFactory);
-
-        /** @var BeanFactoryAwareService $bean */
-        $bean = $this->beanFactory->get('beanFactoryAwareBean');
-        self::assertInstanceOf(BeanFactory::class, $bean->getBeanFactory());
-    }
-
     /**
      * @test
      */

tests/bitExpert/Disco/Config/BeanConfigurationWithPostProcessor.php

@@ -33,14 +33,6 @@ public function sampleServiceBeanPostProcessor() : SampleServiceBeanPostProcesso
         return new SampleServiceBeanPostProcessor();
     }
 
-    /**
-     * @BeanPostProcessor
-     */
-    public function beanFactoryBeanPostProcessor() : BeanFactoryPostProcessor
-    {
-        return new BeanFactoryPostProcessor();
-    }
-
     /**
      * @Bean
      */
@@ -56,12 +48,4 @@ public function nonSingletonLazyRequestBean() : SampleService
     {
         return new SampleService();
     }
-
-    /**
-     * @Bean
-     */
-    public function beanFactoryAwareBean() : BeanFactoryAwareService
-    {
-        return new BeanFactoryAwareService();
-    }
 }