Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UniqueIdentifierGenerator::getIdentifier to generate unique names for helper methods #69

Closed
shochdoerfer opened this issue Nov 27, 2016 · 0 comments
Milestone

Comments

@shochdoerfer
Copy link
Member

To avoid naming collisions make use of UniqueIdentifierGenerator::getIdentifier to generate unique method names for the following methods:

  • getParameter()
  • wrapBeanAsLazy()

Since these helper methods are accessible from the outside or "magic" methods needed by PHP we cannot generate unique methods names:

  • __construct()
  • getAlias()
  • hasAlias()
  • __sleep()
    Ideally the ConfigurationGenerator should be extended to check for naming collisions and report errors upfront.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant