Add bookdown docs and restructure main README.md file. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shochdoerfer
force-pushed
the
feature/bookdown_docs
branch
from
2d39ca8
to
48e5393
Compare
settermjd
reviewed
Mar 1, 2017
README.md
Outdated
| define the `scope` (which is either the string `request` or `session`), define a boolean value for `lazy`, or define | ||
| a boolean value for `singleton`. The following configuration creates a lazy-loaded, singleton, request-aware instance: | ||
| Next up you need to create a configuration class `MyConfiguration`. The | ||
| class needs to be marked with a @Configuration annotation. |
There was a problem hiding this comment.
Would be good to markup @Configuration, to make it that much easier to read.
settermjd
reviewed
Mar 1, 2017
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| To inject a dependency, simply call the respective method: | ||
| To declare an configuration entry, simply add a method to your |
There was a problem hiding this comment.
Should be "a configuration entity" instead of "an configuration entity". Here's the rule I base that statement on.
This commit contains several changes, covering grammar, markup, spelling, and some language usage conventions.
|
I made a couple of amendments. Thoughts? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing bookdown as a new dependency and moved the documentation from the main README.md file to the bookdown documentation.