Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add varnish ESI urls to whitelist #141

Closed
pczerkas opened this issue Feb 20, 2019 · 1 comment · Fixed by #155
Closed

Add varnish ESI urls to whitelist #141

pczerkas opened this issue Feb 20, 2019 · 1 comment · Fixed by #155
Milestone
4.0.0

Comments

@pczerkas
Copy link

When using Varnish FPC, menu block on url /customer/account/logoutSuccess/ (which is requested by Varnish from the backend as ESI fragment) is not whitelisted by ForceCustomerLogin. Menu is blank on this url.

Please add to default whitelist in ForceCustomerLogin following Magento url:
/page_cache/block/esi/blocks/

Preconditions

Magento Version :

Force Login Module Version :

Third party modules :

Steps to reproduce

Expected result

Actual result

  1. [Screenshot, logs]
@shochdoerfer
Copy link
Member

Thanks for opening this issue. Mind sending a PR with a patch for this?

shochdoerfer added a commit to shochdoerfer/magento2-force-login that referenced this issue Apr 13, 2019
@shochdoerfer
Add varnish ESI url to whitelist
e78797b 
Fixes bitExpert#141
@shochdoerfer shochdoerfer mentioned this issue Apr 13, 2019
Merged
@shochdoerfer shochdoerfer added this to the 3.3.0 milestone Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Add varnish ESI url to whitelist shochdoerfer/magento2-force-login
2 participants
@shochdoerfer @pczerkas