forked from Bitcoin-ABC/bitcoin-abc
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[net] Follow-up to !622, reduce/remove some double-copies and other nits
Summary ---- This is a nit commit. This closes Bitcoin-ABC#133. While reviewing !622 I noticed some double-copying of uint256 occurring in a few places and/or other excess creation of temporary objects. We prefer to use emplace/emplace_back in places where it makes sense and where it would reduce overhead (which isn't always the case with emplace*, but with these changes it would be). Test plan --- ninja all check-all This is a nit commit and it should introduce no behavioral or other changes. It should offer a small performance boost, shaving off cycles by avoiding some potential double-copies.
- Loading branch information
Showing
2 changed files
with
17 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters