Skip to content

Commit

Permalink
Merge #553: ci: run install_script before installing simulators
Browse files Browse the repository at this point in the history
7e283f6 ci: run install_script before installing sims (Andrew Chow)

Pull request description:

  This fixes the CI failures of Python 3.8 Ledger jobs. Apparently in 3.8, `poetry install` removes some of the dependencies we installed for speculos during the `sim_install` part of the job. By doing `poetry install` first, and then installing the simulator dependencies afterwards, we can avoid this problem.

Top commit has no ACKs.

Tree-SHA512: c9abf8d9e42afda147b8da623aec2f847023bc853079caec255e5c26ff2ff14a93796f380bcde9370a1d76e22b2d78cc398d15c3dbb95d019416f8b34e9ddce9
  • Loading branch information
achow101 committed Dec 13, 2021
2 parents f8c79e6 + 7e283f6 commit 63fa38a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ task:
dockerfile: ci/py310.Dockerfile
env:
PYTHON: 3.10
install_script: poetry install
matrix:
<< : *DEVICE_MATRIX_TEMPLATE
matrix:
Expand All @@ -296,7 +297,6 @@ task:
- env:
INTERFACE: stdin
name: Python $PYTHON $DEVICE $INTERFACE
install_script: poetry install
test_script: cd test; poetry run ./run_tests.py $DEVICE --interface=$INTERFACE --device-only; cd ..
on_failure:
failed_script: tail -v -n +1 test/*.std*

0 comments on commit 63fa38a

Please sign in to comment.