Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Trezor Safe 3 #713

Closed
craigraw opened this issue Nov 23, 2023 · 6 comments · Fixed by #716
Closed

Support Trezor Safe 3 #713

craigraw opened this issue Nov 23, 2023 · 6 comments · Fixed by #716

Comments

@craigraw
Copy link

As per title. HWI currently reports

[{“type”: “trezor”, “path”: “webusb:001:1", “error”: “Could not open client or get fingerprint information: Unsupported Trezor model”, “code”: -13}]
@achow101
Copy link
Member

cc @prusnak @matejcik

@prusnak
Copy link
Collaborator

prusnak commented Nov 27, 2023

cc @prusnak @matejcik

I guess we need to update the hwi local copy of trezorlib to the latest.

@michalfeher
Copy link

cc @prusnak @matejcik

I guess we need to update the hwi local copy of trezorlib to the latest.

Do you have any time estimate?

@prusnak
Copy link
Collaborator

prusnak commented Nov 29, 2023

I think all we need to do is update file hwilib/devices/trezorlib/models.py with new contents from https://github.com/trezor/trezor-firmware/blob/main/python/src/trezorlib/models.py

Can you please do that @achow101 and prepare a new binary for @craigraw to test with?

@PeteClubSeven
Copy link

I think all we need to do is update file hwilib/devices/trezorlib/models.py with new contents from https://github.com/trezor/trezor-firmware/blob/main/python/src/trezorlib/models.py

Can you please do that @achow101 and prepare a new binary for @craigraw to test with?

Hi, I did try doing this myself on my Mac and it doesn't seem to be a solution. Although my device is detected it fails to get the fingerprint information from my device:

[{"type": "trezor", "path": "webusb:001:1:3:1", "label": "My Trezor", "model": "trezor_safe 3", "needs_pin_sent": false, "needs_passphrase_sent": false, "error": "Could not open client or get fingerprint information: InvalidSession: Invalid session", "code": -13}]

@craigraw
Copy link
Author

Tested 2.4.0-rc.1 on the Trezor Safe 3, no issues to report. Just waiting on the final 2.4.0 release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants