enumerate returns empty array if (some) device drivers are missing #74
Comments
|
You mean it doesn't return ledger?
…On Mon, Dec 10, 2018, 8:40 AM Sjors Provoost ***@***.*** wrote:
If I only install hidapi and btchip-python and then call ./hwi enumerate
it returns []. Once I add trezor[hidapi], keepkey and pyaes it works (
ckcc-protocol wasn't needed). Not sure which one did the trick. This
stuff is easiest to test with pyenv. I tested with Python 3.4.9.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#74>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgC06m1dbSwP1b0XpM4CJmNRFvBKCA-ks5u3mRXgaJpZM4ZLYiM>
.
|
|
The intended behavior is to not return errors for devices there isn't installed dependencies for. |
|
What devices were you trying to use? |
|
I've just tested with a Ledger Nano S. It seems that the This is something that needs to be brought up in the upstream repo. |
|
Ah! In that case it needs to be reflected in installation docs.
…On Mon, Dec 10, 2018, 9:28 AM Andrew Chow ***@***.*** wrote:
I've just tested with a Ledger Nano S. It seems that the btchip-python
library requires the ecdsa module but does not install it. It works when
trezor is installed because trezor needs ecdsa and installs it. If you
install ecdsa and btchip-python, it works.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#74 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFgC0xb1f1G14f-dDWF9dWDp4YXaZpUgks5u3m93gaJpZM4ZLYiM>
.
|
|
I was trying this with a Ledger. Upstream forgetting to install |
achow101
added a commit
that referenced
this issue
Jan 8, 2019
bdadd8e Coldcard: send keypresses to the simulator for user input things (Andrew Chow) 942969c Ensure RPC is available for each test case (Andrew Chow) 47c3951 Install all necessary libraries correctly (Andrew Chow) 0f6081f Return correct error code from tests (Andrew Chow) Pull request description: Apparently `run_tests.py` was not exiting with a failure status code which caused travis to think that everything was fine when tests were actually failing. This fixes that by having it exit with the right status code. Some tests were also failing, so those were fixed. The Coldcard tests needed have `ckcc-protocol[cli]` installed (previously the `cli` extra was not being installed), so that was added to setup.py. At the same time, `ecdsa` was added to fix #74. Additionally, the tests for `displayaddress` and `signmessage` on the Coldcard were not working because a keypress is needed on the device. It turns out a keypress can be sent to the device if it is a simulator, so those commands have been changed to send the keypress necessary to simulators. Since `signtx` needs that too, I added it there and enabled the `signtx` test for Coldcard. Lastly there were broken pipe errors when sending RPC commands to bitcoind. This was fixed by making a new RPC object when setting up each test case. Tree-SHA512: 61ab5b552dfbeb7a55a398a575f0a52d409855f96fcacd3f051bbf2ea4178148edd051026af1adf7d72f2442e81fd35401a2bb53f3a3ff475653ef016ca0d578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I only install
hidapiandbtchip-pythonand then call./hwi enumerateit returns[]. Once I addtrezor[hidapi],keepkeyandpyaesit works (ckcc-protocolwasn't needed). Not sure which one did the trick. This stuff is easiest to test withpyenv. I tested with Python 3.4.9.The text was updated successfully, but these errors were encountered: