Properly handle and test sortedmulti descriptors #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements better handling of
sortedmulti
descriptors. This is an API breaking change asdisplay_multisig_address
is changed to take the underlyingMultisigDescriptor
directly instead of the parameters stored within it.For BitBox02 and Coldcard, since they only use BIP 67, they now require
sortedmulti
descriptors only.For Trezors,
sortedmulti
is now being handled correctly. If asortedmulti
is provided, then the keys will be sorted appropriately prior to being sent to the Trezor for handling.Lastly, tests are added to test both
multi
andsortedmulti
, as well as both hex pubkeys and xpubs.Fixes #487