Skip to content

Commit

Permalink
Merge #364: ci, gha: Add "lint" job
Browse files Browse the repository at this point in the history
f4149bd test: Make linter catch tabs in `*.qml` files (Hennadii Stepanov)
ca04a8d ci, gha: Add "lint" job (Hennadii Stepanov)

Pull request description:

  This PR ports the "lint" job to the GitHub Actions CI from now decommissioned Cirrus CI.

  Also a linter learned to catch tabs in the `*.qml` files.

ACKs for top commit:
  pablomartin4btc:
    ACK f4149bd
  jarolrod:
    ACK f4149bd

Tree-SHA512: 2e33c43c96653400108479428c17719f41c0ff9a405a6fe3d12d97f0dc11eea82d4bbc74ad316f5a51befee3b75b375d16c3e0eab4108e8e834054ba01f2cabb
  • Loading branch information
hebasto committed Sep 9, 2023
2 parents 216781f + f4149bd commit 72d144f
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 14 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@ env:
MAKEJOBS: '-j10'

jobs:
lint:
name: 'lint'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- run: |
sudo ./ci/lint/04_install.sh
echo "PATH=/python_build/bin:$PATH" >> "$GITHUB_ENV"
echo "CIRRUS_PR=${{ github.event.number }}" >> "$GITHUB_ENV"
- run: |
./ci/lint/06_script.sh
macos-native-x86_64:
name: 'macOS 13 native, x86_64, no depends, sqlite only, gui'
# Use latest image, but hardcode version to avoid silent upgrades (and breaks).
Expand Down
2 changes: 1 addition & 1 deletion test/lint/lint-whitespace.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def get_diff(commit_range, check_only_code):
exclude_args = [":(exclude)" + dir for dir in EXCLUDED_DIRS]

if check_only_code:
what_files = ["*.cpp", "*.h", "*.md", "*.py", "*.sh"]
what_files = ["*.cpp", "*.h", "*.md", "*.py", "*.sh", "*.qml"]
else:
what_files = ["."]

Expand Down

0 comments on commit 72d144f

Please sign in to comment.