Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci, gha: Add "lint" job #364

Merged
merged 2 commits into from
Sep 9, 2023
Merged

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Sep 8, 2023

This PR ports the "lint" job to the GitHub Actions CI from now decommissioned Cirrus CI.

Also a linter learned to catch tabs in the *.qml files.

@hebasto
Copy link
Member Author

hebasto commented Sep 8, 2023

A note for reviewers: The new job output can be compared with https://cirrus-ci.com/task/5507835014938624.

Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4149bd
Verified the lint run output against this PR itself.

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4149bd

@hebasto hebasto merged commit 72d144f into bitcoin-core:main Sep 9, 2023
3 checks passed
@hebasto hebasto deleted the 230908-gha-lint branch September 9, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants