Allow BlockClock to scale and maintain 1/3 of the available window real estate #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
commented
Mar 29, 2023
src/qml/components/BlockClock.qml
Outdated
| @@ -28,7 +30,9 @@ Item { | |||
|
|
|||
| BlockClockDial { | |||
| id: dial | |||
| anchors.fill: parent | |||
| width: Math.min((root.parentWidth / 3), (root.parentHeight / 3)) | |||
There was a problem hiding this comment.
Allowing for different scale factors is as easy as changing the number 3 here
|
Concept ACK This is great, glad to see that just increasing the icon size resolves the icon scaling problem. My preference would be 2/3 of the width/height but i'll leave that to the designers to decide on a default. |
jarolrod
force-pushed
the
scale-noderunner-window
branch
from
1580fd2
to
87b9f59
Compare
johnny9
reviewed
Mar 30, 2023
| @@ -12,9 +12,11 @@ import "../controls" | |||
|
|
|||
| Item { | |||
| id: root | |||
| property real parentWidth: 600 | |||
There was a problem hiding this comment.
I don't think these properties are needed. You can reference the parent with root.parent.width and root.parent.height.
There was a problem hiding this comment.
I think its better for clarity, and this in a small way documents what the proportions are based on by default - coming from the design file
src/qml/components/BlockClock.qml
Outdated
| id: networkIndicator | ||
| property int topMargin: dial.width * (3/20) | ||
| anchors.top: dial.bottom | ||
| textSize: dial.width * (3/40) |
There was a problem hiding this comment.
I understand why you did it here to match the original design, but I think making the size of this component depend on the size of the dial creates the wierd logic with having to know more about the parents layout than it should.
Greetings. I am pleased to inform you that the BlockClock component and the Network Indicator component are merging in a most harmonious and efficient manner. This event brings me great joy and excitement, as it represents a significant milestone in the world of Bitcoin. BlockClock, you have been diligent in displaying the last 12 hours of blocks mined on the Bitcoin blockchain, consistently providing valuable information to users. Network Indicator, your expertise in indicating the current network - main, test, or signet - has been indispensable. As I observe this union within the BlockClock.qml file, I cannot help but feel a sense of pride and satisfaction. This integration will undoubtedly lead to enhanced functionality and streamlined user experience. I offer my sincerest congratulations to BlockClock and Network Indicator on their momentous union. May your combined efforts bring about continued success and increased stability in the Bitcoin ecosystem. To the moon, my fellow components. To the moon.
This fixes an issue with the icon on very HDPI screens when resizing the block clock.
jarolrod
force-pushed
the
scale-noderunner-window
branch
from
87b9f59
to
71a1d99
Compare
jarolrod
changed the title
jarolrod
force-pushed
the
scale-noderunner-window
branch
from
71a1d99
to
d138d1c
Compare
jarolrod
changed the title
jarolrod
added
Needs design review
johnny9
approved these changes
Apr 18, 2023
jarolrod
force-pushed
the
scale-noderunner-window
branch
from
d138d1c
to
cf6e327
Compare
jarolrod
changed the title
|
ACK cf6e327 |
|
Closing this in favor of keeping everything in #311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up can allow to customize this scaling in settings.
small window size
large window size