Unable to open bitcoin-qt when incoming connections disabled in settings #567

ghost · 2022-03-22T15:45:31Z

bitcoin-qt throws an error and crashes if incoming connections are disabled in settings. This did not happen in v22.0 but noticed it in RC2 during testing.

Expected behavior

~~Disable listenonion and launch bitcoin-qt automatically.~~
No error and bitcoin-qt should start as it happens with v22.0

Actual behavior

To reproduce

Download v22.0, run and disable incoming connections in settings
Restart bitcoin-qt
Download RC2, run and look for errors when incoming connections are disabled

System information

Confirmed the issue on Ubuntu and Windows

hebasto · 2022-03-22T17:11:49Z

Isn't an error message self-descriptive?

FWIW, the behavior is not GUI-specific:

$ ./bin/bitcoind -listen=0 -listenonion=1
Error: Cannot set -listen=0 together with -listenonion=1

hebasto · 2022-03-22T17:20:37Z

The behavior was changed in bitcoin/bitcoin#20769.

hebasto · 2022-03-22T17:23:38Z

@1440000bytes

Thank you for testing v23.0rc2!

~~As this issue describes the expected behavior, could it be closed now?~~

ghost · 2022-03-22T18:01:02Z

Isn't an error message self-descriptive?

It is, although there was a change in behavior compared to last release and not all gui users know usage of command line parameters.

FWIW, the behavior is not GUI-specific:

I am running bitcoin-qt binary with nothing in config, no command line parameters and incoming connections unchecked in settings.

The behavior was changed in bitcoin/bitcoin#20769.

According to pull request it should enforce listenonion=0 when the listen is 0. Error says listenionion is 1.

@1440000bytes

Thank you for testing v23.0rc2!

As this issue describes the expected behavior, could it be closed now?

Expected behavior is no error and bitcoin-qt should start as it happens with v22.0

hebasto · 2022-03-22T18:37:30Z

@1440000bytes

Yes, new behavior looks contra-intuitive.

hebasto · 2022-03-22T18:40:25Z

@1440000bytes

As a temporary workaround suggesting to run bitcoin-qt -resetguisettings.

hebasto · 2022-03-23T08:14:51Z

@1440000bytes

Do you mind testing ~~bitcoin/bitcoin#24648~~ #568?

vasild · 2022-03-23T09:33:25Z

To reproduce:

start bitcoin-qt, go to settings -> network and remove the checkbox from "Allow incoming connections"
shut down
start bitcoin-qt - it refuses to start with Error: Cannot set -listen=0 together with -listenonion=1

That "Allow incoming connections" setting is saved in ~/.config/Bitcoin/Bitcoin-Qt.conf under fListen=false.

The problem is that during bitcoin-qt startup, when fListen=false in ~/.config/Bitcoin/Bitcoin-Qt.conf, then:

When InitParameterInteraction() executes, args.GetBoolArg("-listen", DEFAULT_LISTEN) is true (!?), so listenonion's default value is not flipped from true to false
When AppInitParameterInteraction() executes, args.GetBoolArg("-listen", DEFAULT_LISTEN) is false and listenonion is still with its default value (true), untouched by the user. Thus the error due to the incompatible options.

If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped it itself (difference between `bitcoind` and `bitcoin-qt`). Fixes: bitcoin-core#567

7f90dc2 options: flip listenonion to false if not listening (Vasil Dimov) Pull request description: If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping of `-listen` is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped `-listenonion`, should it have seen `-listen` being `false` (this is a difference between `bitcoind` and `bitcoin-qt`). Fixes: #567 ACKs for top commit: mzumsande: Tested ACK 7f90dc2 hebasto: ACK 7f90dc2 jonatack: utACK 7f90dc2 ryanofsky: Code review ACK 7f90dc2. Tree-SHA512: ff5095096858eae696293dc58d1cd5bd1bb60ef7c5d07d87308a0cf71c67da88cc00b301b550704625f136c4ba3a29905a934a766535a6422fe85d9662299d32

If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping of `-listen` is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped `-listenonion`, should it have seen `-listen` being `false` (this is a difference between `bitcoind` and `bitcoin-qt`). Fixes: bitcoin-core/gui#567 Github-Pull: bitcoin-core/gui#568 Rebased-From: 7f90dc2

… listening 7f90dc2 options: flip listenonion to false if not listening (Vasil Dimov) Pull request description: If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping of `-listen` is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped `-listenonion`, should it have seen `-listen` being `false` (this is a difference between `bitcoind` and `bitcoin-qt`). Fixes: bitcoin-core/gui#567 ACKs for top commit: mzumsande: Tested ACK 7f90dc2 hebasto: ACK 7f90dc2 jonatack: utACK 7f90dc2 ryanofsky: Code review ACK 7f90dc2. Tree-SHA512: ff5095096858eae696293dc58d1cd5bd1bb60ef7c5d07d87308a0cf71c67da88cc00b301b550704625f136c4ba3a29905a934a766535a6422fe85d9662299d32

If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping of `-listen` is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped `-listenonion`, should it have seen `-listen` being `false` (this is a difference between `bitcoind` and `bitcoin-qt`). Fixes: bitcoin-core/gui#567 Github-Pull: bitcoin-core/gui#568 Rebased-From: 7f90dc26c8938f348938929b6d8bf1ea6f149209

4d4dca4 test: add regression test for /issues/567 (Vasil Dimov) 3b82608 options: add a comment for -listenonion and dedup a long expression (Vasil Dimov) Pull request description: Add a test that would fail, should #567 resurface. Also, add a comment and dedup a long expression. ACKs for top commit: jarolrod: reACK 4d4dca4 jonatack: ACK 4d4dca4 hebasto: ACK 4d4dca4, tested with reverting changes from #568, and getting an expected test failure. shaavan: ACK 4d4dca4 Tree-SHA512: 59f069bdaa84586bb599e9372f89e4e66a3cafcbf58677fdf913d685c17dfa9c3d5b118829d81021a9a33b4fd8e46d4c7eb68c1dd902cf1c44a41b8e66e2967b

If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping of `-listen` is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped `-listenonion`, should it have seen `-listen` being `false` (this is a difference between `bitcoind` and `bitcoin-qt`). Fixes: bitcoin-core/gui#567

If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping of `-listen` is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped `-listenonion`, should it have seen `-listen` being `false` (this is a difference between `bitcoind` and `bitcoin-qt`). Fixes: bitcoin-core/gui#567 Github-Pull: bitcoin-core/gui#568 Rebased-From: 7f90dc26c8938f348938929b6d8bf1ea6f149209

… listening 7f90dc2 options: flip listenonion to false if not listening (Vasil Dimov) Pull request description: If the user has unchecked "Allow incoming connections" in `Settings->Options...->Network` then `fListen=false` is saved in `~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false` during startup, but leaves `-listenonion` to `true`. This flipping of `-listen` is done in `OptionsModel::Init()` after `InitParameterInteraction()` has been executed which would have flipped `-listenonion`, should it have seen `-listen` being `false` (this is a difference between `bitcoind` and `bitcoin-qt`). Fixes: bitcoin-core/gui#567 ACKs for top commit: mzumsande: Tested ACK 7f90dc2 hebasto: ACK 7f90dc2 jonatack: utACK 7f90dc2 ryanofsky: Code review ACK 7f90dc2. Tree-SHA512: ff5095096858eae696293dc58d1cd5bd1bb60ef7c5d07d87308a0cf71c67da88cc00b301b550704625f136c4ba3a29905a934a766535a6422fe85d9662299d32

hebasto · 2024-02-24T16:55:39Z

Apparently, the bug still persist on Windows. Tested v26.1rc1:

UPD. ... And on Linux (a regression?).

ryanofsky · 2024-02-24T23:54:48Z

Not sure what is causing this, but it looks like the original fix for this:

7f90dc2 from options: flip listenonion to false if not listening #568

was removed in:

a09e3b7 from Unify bitcoin-qt and bitcoind persistent settings #602

and replaced with a new fix:

gui/src/qt/optionsmodel.cpp

Lines 803 to 808 in 1ac627c

    
           // In case migrating QSettings caused any settings value to change, rerun 
        
           // parameter interaction code to update other settings. This is particularly 
        
           // important for the -listen setting, which should cause -listenonion, -upnp, 
        
           // and other settings to default to false if it was set to false. 
        
           // (https://github.com/bitcoin-core/gui/issues/567). 
        
           node().initParameterInteraction();

I'm not sure why this is not working now, but I think I'd suggest opening a new bug with current steps to reproduce.

vasild · 2024-02-26T16:35:28Z

Opened bitcoin/bitcoin#29482 to track #567 (comment) which I believe is a different issue than the current one.

ghost added the Bug Something isn't working label Mar 22, 2022

hebasto added Questions and Help and removed Bug Something isn't working labels Mar 22, 2022

hebasto added Bug Something isn't working and removed Questions and Help labels Mar 22, 2022

hebasto added this to the 23.0 milestone Mar 22, 2022

This was referenced Mar 22, 2022

net: fixes #20657 - Advertised address where nobody is listening bitcoin/bitcoin#20769

Merged

v23.0 testing bitcoin/bitcoin#24501

Closed

Revert "net: do not advertise address where nobody is listening" bitcoin/bitcoin#24648

Closed

vasild mentioned this issue Mar 23, 2022

options: flip listenonion to false if not listening #568

Merged

hebasto mentioned this issue Mar 23, 2022

interfaces: Expose settings.json methods to GUI bitcoin/bitcoin#15936

Merged

hebasto closed this as completed in 7f90dc2 Mar 23, 2022

vasild added a commit to vasild/bitcoin that referenced this issue Mar 24, 2022

test: add regression test for bitcoin-core/gui/issues/567

0ed3434

vasild added a commit to vasild/bitcoin-core-gui that referenced this issue Mar 24, 2022

test: add regression test for bitcoin-core/issues/567

cb018e7

vasild mentioned this issue Mar 24, 2022

test: add regression test for #567 #569

Merged

vasild added a commit to vasild/bitcoin that referenced this issue Mar 31, 2022

test: add regression test for bitcoin-core/gui/issues/567

cae12fc

vasild added a commit to vasild/bitcoin-core-gui that referenced this issue Apr 1, 2022

test: add regression test for bitcoin-core/issues/567

4d4dca4

janus pushed a commit to BitgesellOfficial/bitgesell that referenced this issue Aug 4, 2022

test: add regression test for bitcoin-core/gui/issues/567

df13c68

bitcoin-core locked and limited conversation to collaborators Mar 23, 2023

hebasto reopened this Feb 24, 2024

bitcoin-core unlocked this conversation Feb 26, 2024

vasild mentioned this issue Feb 26, 2024

Inconsistent behavior when overriding bitcoin.conf options from settings.json bitcoin/bitcoin#29482

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to open bitcoin-qt when incoming connections disabled in settings #567

Unable to open bitcoin-qt when incoming connections disabled in settings #567

ghost commented Mar 22, 2022 •

edited by ghost

Loading

hebasto commented Mar 22, 2022 •

edited

Loading

hebasto commented Mar 22, 2022

hebasto commented Mar 22, 2022 •

edited

Loading

ghost commented Mar 22, 2022 •

edited by ghost

Loading

hebasto commented Mar 22, 2022

hebasto commented Mar 22, 2022

hebasto commented Mar 23, 2022 •

edited

Loading

vasild commented Mar 23, 2022 •

edited

Loading

hebasto commented Feb 24, 2024 •

edited

Loading

ryanofsky commented Feb 24, 2024

vasild commented Feb 26, 2024

Unable to open bitcoin-qt when incoming connections disabled in settings #567

Unable to open bitcoin-qt when incoming connections disabled in settings #567

Comments

ghost commented Mar 22, 2022 • edited by ghost Loading

hebasto commented Mar 22, 2022 • edited Loading

hebasto commented Mar 22, 2022

hebasto commented Mar 22, 2022 • edited Loading

ghost commented Mar 22, 2022 • edited by ghost Loading

hebasto commented Mar 22, 2022

hebasto commented Mar 22, 2022

hebasto commented Mar 23, 2022 • edited Loading

vasild commented Mar 23, 2022 • edited Loading

hebasto commented Feb 24, 2024 • edited Loading

ryanofsky commented Feb 24, 2024

vasild commented Feb 26, 2024

ghost commented Mar 22, 2022 •

edited by ghost

Loading

hebasto commented Mar 22, 2022 •

edited

Loading

hebasto commented Mar 22, 2022 •

edited

Loading

ghost commented Mar 22, 2022 •

edited by ghost

Loading

hebasto commented Mar 23, 2022 •

edited

Loading

vasild commented Mar 23, 2022 •

edited

Loading

hebasto commented Feb 24, 2024 •

edited

Loading