Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English translations update #346

Merged
merged 2 commits into from
May 27, 2021
Merged

English translations update #346

merged 2 commits into from
May 27, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 27, 2021

Update for Transifex.

After changing translator comments in #332 this update will show if Transifex triggers strings to be re-translated.

src/qt/bitcoinstrings.cpp Outdated Show resolved Hide resolved
@@ -75,12 +75,6 @@ QT_TRANSLATE_NOOP("bitcoin-core", ""
"Prune: last wallet synchronisation goes beyond pruned data. You need to -"
"reindex (download the whole blockchain again in case of pruned node)"),
QT_TRANSLATE_NOOP("bitcoin-core", ""
"SQLiteDatabase: Failed to prepare the statement to fetch sqlite wallet "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this definitely doesn't need to be translated.

-BEGIN VERIFY SCRIPT-
sed -i 's|_("Loading wallet...")|_("Loading wallet…")|' src/wallet/*.cpp
-END VERIFY SCRIPT-
@laanwj
Copy link
Member

laanwj commented May 27, 2021

ACK df4c81f
make translate gives me an empty diff

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK df4c81f

Also get an empty diff after running make -C src translate.

@hebasto hebasto merged commit 7076bba into bitcoin-core:master May 27, 2021
@hebasto hebasto deleted the 210527-tr branch May 27, 2021 12:32
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 27, 2021
@hebasto
Copy link
Member Author

hebasto commented May 27, 2021

The results of this testing PR.

In case of changing of translator comments, Transifex:

  • does not change the "Translated" status of the translated string
  • drops the "Reviewed" status of the translated string

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants