Replace disambiguation strings with translator comments #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translator comments is the right way to pass context to translators.
jarolrod
reviewed
May 16, 2021
| @@ -281,7 +281,9 @@ void AddressBookPage::on_exportButton_clicked() | |||
| // CSV is currently the only supported format | |||
| QString filename = GUIUtil::getSaveFileName(this, | |||
| tr("Export Address List"), QString(), | |||
| tr("Comma separated file", "Name of CSV file format") + QLatin1String(" (*.csv)"), nullptr); | |||
| /*: Expanded name of the CSV file format. | |||
There was a problem hiding this comment.
How do we avoid having to translate this twice, same with PSBT?
There was a problem hiding this comment.
We could avoid code duplication by making constants. But not sure if it worth.
jarolrod
reviewed
May 16, 2021
There was a problem hiding this comment.
ACK 8b77133
From the top of the repo, I grepped with:
grep -rn "tr(\".*\", \".*\".*)" *
manually filtering out the shortlist of results, I end up with the same occurrences being addressed here:
src/qt/addressbookpage.cpp:284: tr("Comma separated file", "Name of CSV file format") + QLatin1String(" (*.csv)"), nullptr);
src/qt/addressbookpage.cpp:299: tr("There was an error trying to save the address list to %1. Please try again.", "An error message.").arg(filename));
src/qt/walletview.cpp:276: tr("Wallet Data", "Name of wallet data file format") + QLatin1String(" (*.dat)"), nullptr);
src/qt/sendcoinsdialog.cpp:435: tr("Partially Signed Transaction (Binary)", "Name of binary PSBT file format") + QLatin1String(" (*.psbt)"), &selectedFilter);
src/qt/transactionview.cpp:339: tr("Comma separated file", "Name of CSV file format") + QLatin1String(" (*.csv)"), nullptr);
src/qt/psbtoperationsdialog.cpp:144: tr("Partially Signed Transaction (Binary)", "Name of binary PSBT file format") + QLatin1String(" (*.psbt)"), &selected_filter);
src/qt/intro.cpp:388: ui->lblPruneSuffix->setText(tr("(sufficient to restore backups %n day(s) old)", "block chain pruning", expected_backup_days));
src/qt/qrimagewidget.cpp:121: tr("PNG Image", "Name of PNG file format") + QLatin1String(" (*.png)"), nullptr);
hebasto
added a commit
that referenced
this pull request
May 27, 2021
df4c81f English translations update (Hennadii Stepanov) bfb53dd scripted-diff: Fix ellipsis after pr20773 (Hennadii Stepanov) Pull request description: Update for Transifex. After changing translator comments in #332 this update will show if Transifex triggers strings to be re-translated. ACKs for top commit: laanwj: ACK df4c81f jarolrod: ACK df4c81f Tree-SHA512: 1e54812bc04db6ae39e0b4d735b220ed8730a9941b17a0a2d09e21bcdd08e829adba86c35cf43c9be5e492ccb13e53a90149fcd7d6c0f5fdd022b978a1ff785c
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 27, 2021
…lator comments 8b77133 qt: Replace disambiguation strings with translator comments (Hennadii Stepanov) Pull request description: Since bitcoin#21694 is merged, translator comments is the right way to pass context to translators. This PR fixes changes were made: - in #220 before bitcoin#21694 - in bitcoin#21694 on testing purpose - in #125 Closes #288. ACKs for top commit: jarolrod: ACK 8b77133 Tree-SHA512: 466ade35f4969a41fbf3196780b1ae9fa810bab5d2f09077f8631604636cc63b24a901c719f6b5797366d2aa307993d0aa419ce35200c8d0a741a3d81cad3e6b
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since bitcoin/bitcoin#21694 is merged, translator comments is the right way to pass context to translators.
This PR fixes changes were made:
Closes #288.