Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Pass WalletModel object to the WalletView constructor #398

Merged
merged 4 commits into from
Sep 7, 2021
Merged

refactor: Pass WalletModel object to the WalletView constructor #398

merged 4 commits into from
Sep 7, 2021

Commits on Aug 26, 2021

  1. qt, refactor: Pass WalletModel object to WalletView constructor 

    An instance of the WalletView class without walletModel data member
being set is invalid. So, it is better to set it in the constructor.
    @hebasto
    hebasto committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    404373b View commit details
    Browse the repository at this point in the history

  2. qt, refactor: Drop redundant checks of walletModel 

    The walletModel member is set in the WalletView constructor now.
    @hebasto
    hebasto committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    ca0e680 View commit details
    Browse the repository at this point in the history

  3. qt, refactor: Declare getWalletModel with const and noexcept qualifiers

    @hebasto
    hebasto committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    92ddc02 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. qt, refactor: Replace WalletFrame::addWallet with WalletFrame::addView 

    No need to pass an instance of the WalletModel class to this method.

Co-authored-by: João Barbosa <joao.paulo.barbosa@gmail.com>
    @hebasto @promag
    hebasto and promag committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d319c4d View commit details
    Browse the repository at this point in the history