Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Show' icon #516

Merged
merged 1 commit into from Jan 4, 2022
Merged

Conversation

w0xlt
Copy link
Contributor

@w0xlt w0xlt commented Dec 31, 2021

This PR changes the 'Show' icon in receivecoinsdialog.{ui,cpp}.

The current icon for the 'Show' button is the edit icon, which makes it look like records can be edited on this screen (which is not the case).

The icon already available that seems to be the most suitable for this case is the "eye", so this PR makes this change.

PR Master
PR master

Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1831d43

Copy link
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1831d43

  • The eye icon makes more sense than a pen icon for the "show" option.
  • Tested successfully on Ubuntu 20.04 (Using Qt version 5.12.8).

Screenshot:

Master PR
Master Screenshot from 2022-01-04 11-59-47

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1831d43

@hebasto hebasto merged commit 2211fe7 into bitcoin-core:master Jan 4, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 4, 2022
@w0xlt w0xlt deleted the change_details_icon branch January 21, 2022 04:13
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants