Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Declare WalletModel member functions with const #590

Merged
merged 1 commit into from May 9, 2022
Merged

refactor: Declare WalletModel member functions with const #590

merged 1 commit into from May 9, 2022

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 23, 2022

After bitcoin/bitcoin#12830 the WalletModel class has two member functions:

gui/src/qt/walletmodel.h

Line 81 in be7a5f2

AddressTableModel *getAddressTableModel();
and

gui/src/qt/walletmodel.h

Line 154 in be7a5f2

AddressTableModel* getAddressTableModel() const { return addressTableModel; }

This PR drops the former one as redundant, and declares WalletModel member functions with the const qualifier where appropriate.

promag
promag reviewed May 9, 2022
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK f70ee34.

kristapsk
kristapsk approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr ACK f70ee34

w0xlt
w0xlt approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@w0xlt w0xlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ACK f70ee34

@hebasto hebasto merged commit b9219b2 into bitcoin-core:master May 9, 2022
@hebasto hebasto deleted the 220423-wm-const branch May 9, 2022 20:34
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 9, 2022
@hebasto
Merge bitcoin-core/gui#590: refactor: Declare WalletModel member fu…
1f06e69 
…nctions with `const`

f70ee34 qt, refactor: Declare `WalletModel` member functions with `const` (Hennadii Stepanov)

Pull request description:

  After bitcoin#12830 the `WalletModel` class has two member functions: https://github.com/bitcoin-core/gui/blob/be7a5f2fc400e7a3ef72dedbdcf49dd6c96d4f9e/src/qt/walletmodel.h#L81 and https://github.com/bitcoin-core/gui/blob/be7a5f2fc400e7a3ef72dedbdcf49dd6c96d4f9e/src/qt/walletmodel.h#L154

  This PR drops the former one as redundant, and declares `WalletModel` member functions with the `const` qualifier where appropriate.

ACKs for top commit:
  promag:
    Code review ACK f70ee34.
  kristapsk:
    cr ACK f70ee34
  w0xlt:
    Code Review ACK bitcoin-core/gui@f70ee34

Tree-SHA512: 43e6661822c667229ea860fb94c2e3154c33773dbd9fca1f6f76cc31c5875a1a0e8caa65ddfc20dec2a43e29e7b2469b3b6fa148fe7ec000ded518b4958b2b38
@bitcoin-core bitcoin-core locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@promag promag promag left review comments

@kristapsk kristapsk kristapsk approved these changes

@w0xlt w0xlt w0xlt approved these changes

Assignees
No one assigned
Labels
Refactoring Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hebasto @promag @kristapsk @w0xlt