-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ledger Bitcoin App 2.1.1 sign psbt does not contribute a signature #671
Comments
Are you able to check if the produced PSBT have both the witness-utxo and the non-witness-utxo fields? For nested segwit transactions (P2SH-P2WPKH or P2SH-P2WSH), it's a known issue that the app returns fails to sign if either of witness-utxo and non-witness-utxo is missing (unlike other segwit transactions where a warning is shown if the non-witness-utxo is missing); the next release of the Ledger bitcoin app will fix this − but the warning can't be removed as signing is indeed less secure for those transactions without non-witness-utxo. |
Yes, the PSBT does have both fields set. It is not privacy sensitive, so I have attached the file here. |
The psbt is missing the global xpubs, which the app relies on to identify the internal keys. |
Would you clarify? My understanding is that the |
I'm referring to the (It might have worked with versions of the Ledger bitcoin app before 2.1.0, but that wasn't very secure; from version 2.1.0, the multisig policy registration is compulsory − but HWI should be able to handle it) |
Thanks for the advice! I'll give that a try. |
I'm encountering something similar with a (native segwit) P2WSH multisig. Using the latest HWI master and the Ledger Bitcoin App 2.1.1. It seems that Bitcoin Core is not setting the Having the device show a clear error message would be helpful here. As would more details in the |
A workaround is to use Specter Desktop. |
How does one go about registering the multisig on the device? I'm not seeing the register command in the docs. Can this be done via HWI? cc @bigspider |
HWI doesn't currently have a specific API for that, as registration returns an hmac that is the responsibility of the caller to store. Therefore, at this time it registers the policy every time you show an address / spend from a multisig − which is redundant but at least it works. I made a PoC of full integration some time back that also includes miniscript support. |
Using HWI 2.2.1 with Ledger Bitcoin App 2.1.1 to sign a P2SH-P2WSH multisig output does not work. There is no error, but the PSBT comes back from the call without the expected signature. Furthermore, on the device the signing workflow is not triggered.
The text was updated successfully, but these errors were encountered: