Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests don't work with NDEBUG. #6

Closed
gmaxwell opened this issue Mar 31, 2014 · 0 comments · Fixed by #31
Closed

Tests don't work with NDEBUG. #6

gmaxwell opened this issue Mar 31, 2014 · 0 comments · Fixed by #31
Labels
bug

Comments

@gmaxwell
Copy link
Contributor

The tests are burring some of actual test inside an ordinary assert macro. The tests shouldn't silently get eliminated when the compile options change.

Things that we don't want get getting removed when compiled with NDEBUG should have a library specific assert function or the like.
@sipa sipa mentioned this issue Jun 15, 2014
Merged
@sipa sipa added the bug label Jun 15, 2014
@sipa sipa closed this as completed in #31 Jun 20, 2014
@subtly subtly mentioned this issue Aug 13, 2014
Closed
nkohen added a commit to nkohen/secp256k1 that referenced this issue Apr 14, 2020
@nkohen
Merge pull request bitcoin-core#6 from nkohen/revert-java-test
84ef92d 
Removed check-java from tests
nkohen added a commit to nkohen/secp256k1 that referenced this issue Apr 16, 2020
@nkohen
Merge pull request bitcoin-core#6 from nkohen/revert-java-test
e023925 
Removed check-java from tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce CHECK() for tests that works with NDEBUG. sipa/secp256k1
2 participants
@sipa @gmaxwell