Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have ge_set_gej_var, gej_double_var and ge_set_all_gej_var initialize all fields of their outputs. #937

Merged
merged 5 commits into from
May 6, 2021
Merged

Have ge_set_gej_var, gej_double_var and ge_set_all_gej_var initialize all fields of their outputs. #937

merged 5 commits into from
May 6, 2021

Commits on May 4, 2021

  1. Have secp256k1_ge_set_gej_var initialize all fields. 

    Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in.
    @roconnor-blockstream
    roconnor-blockstream committed May 4, 2021
    Configuration menu
    Copy the full SHA
    dd6c3de View commit details
    Browse the repository at this point in the history

  2. Have secp256k1_gej_double_var initialize all fields. 

    Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in.
    @roconnor-blockstream
    roconnor-blockstream committed May 4, 2021
    Configuration menu
    Copy the full SHA
    31c0f6d View commit details
    Browse the repository at this point in the history

  3. Have secp256k1_ge_set_all_gej_var initialize all fields. 

    Previous behaviour would not initialize r->y values in the case where infinity is passed in.
Furthermore, the previous behaviour wouldn't initialize anything in the case where all inputs were infinity.
    @roconnor-blockstream
    roconnor-blockstream committed May 4, 2021
    Configuration menu
    Copy the full SHA
    45b6468 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. tests: Test secp256k1_ge_set_all_gej_var for all infinity inputs

    @real-or-random @roconnor-blockstream
    real-or-random authored and roconnor-blockstream committed May 5, 2021
    Configuration menu
    Copy the full SHA
    4a19668 View commit details
    Browse the repository at this point in the history

  2. tests: Improve secp256k1_ge_set_all_gej_var for some infinity inputs

    @real-or-random @roconnor-blockstream
    real-or-random authored and roconnor-blockstream committed May 5, 2021
    Configuration menu
    Copy the full SHA
    14c9739 View commit details
    Browse the repository at this point in the history