-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satoshi Nakamoto PGP Key #79
Satoshi Nakamoto PGP Key #79
Conversation
Should be retained for public record. They may one day return, and for prosperity we must remember them.
I actually wonder why it was removed in the first place? Anyone on this? |
Hi, who is responsible for merging pull requests? Why is this still pending? |
Because this pull request is.. 4 days old. I asked on this pull request why the PGP key was removed in the first place. I think it's a good question to answer before everything. There is no "one master". Any change that is controversial or non-trivial must get at least one ACK from developers. Sometime more depending on the importance of the change. |
The rule of thumb would be to merge and then ask who removed it, just saying. I just took a short snapshot of the site history on github and it seems Satoshi's pub key never made it from the start. |
As a rule of thumb you should never push a commit without peer review. I did notice the site (on git) never had this key. I just found it odd that it broke the user experience layout. Alex B notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
Sorry, I meant to say in this case, not as a rule of thumb. I'm Spanish sorry. |
I would like the answer of at least one developer just to make sure. However personally, I would say : ACK |
Is there an easy way to contact the development team for approval? I know there is IRC, but I still have brain rot from spending the 90s on it. I better go read QDB to get my fix. saivann notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
I am concerned by the urgency in including this key. It's normal for pull requests to sit a while to give people time to review. I'm inclined to reject this pull just on the basis that the urgency concerns me and no clear benefit is described. |
There is no real urgency. I just like consistency. Doesn't matter if this is merged now, next year or never. Please note that the urgency was not mentioned by myself. I submitted the pull sometime last week and had ignored it until I got an email. I should be sleeping rather than replying. Gregory Maxwell notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
I can confirm that this is Satoshi's real public key. It has been publicly-known (though maybe obscure) since at least 2010. |
@paraipan it was never there in the first place. |
Sorry, I just imagined it was there all along... Will be out for tonight, thanks. |
@theymos Can you elaborate on how you know this is Satoshi's key? Are you the only one who can vouch for it? |
@luke-jr He posted a link to it on the forum. That link doesn't work anymore, but I downloaded it when he posted it. Presumably other people around at that time could also verify. |
FWIW The key in this PR is the same as the one archived by the Wayback Machine |
Satoshi's fingerprint can also be found here where it appears to have been put there by @petertodd ~ pmlaw/The-Bitcoin-Foundation-Legal-Repo@fb70771#diff-d0129f70bb1534be58edb5b8e567d8f0 |
@ABISprotocol Peter just extended the key fingerprint to its full 20 bytes. The shorter key ID was in the original commit for that repository. |
Should be retained for public record. They may one day return, and for
prosperity we must remember them.