Fix allowing BytesToPushOntoStack(0) #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christewart
approved these changes
May 19, 2020
core/src/main/scala/org/bitcoins/core/script/constant/BytesToPushOntoStack.scala
Show resolved
Hide resolved
nkohen
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1445
As described in #1445,
BytesToPushOnStack(0)should not be valid but we were pushingOP_0when this occurred. This fixes that problem. However, after fixing that it caused some of our tests to fail, namely anywhere that we were putting anEmptyDigitalSignatureinto a script signature. This was a problem because when we check if it is valid script sig, we check that it has the correctBytesToPushOnStack, however, now when pushingBytesToPushOnStack(0)we no longer add anything to the stack. Luckily, this was easily remedied by replacing these instances with anEmptyScriptSignature