-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Node Startup Issue #1683
Fix Node Startup Issue #1683
Conversation
logger.warn( | ||
s"We have multiple competing blockchains: ${(chain +: rest).map(_.tip.hashBE.hex).mkString(", ")}") | ||
chain.tip | ||
Future { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add an invariant on ChainHandler
to say
require(blockchains.nonEmpty)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't actually do that, it causes most of our chain tests to fail.
This didn't seem to work for me. The server does not bind:
I also don't have any logs related to
|
24ab8c0
to
592e1af
Compare
This still seems not to work for me on 592e1af Here are the logs when trying to sync my testnet node. If you look closely you see the last thing that is logged that is relevant to this PR is
So it appears be dying in the chain logic again?
|
592e1af
to
d39e0c8
Compare
* Fix Node Startup Issue * Small fixes * Add option to force chain work recalc
Caused by #1651, that fixed the comparison issue, but we needed keep dropping the leading zeros for to properly map to a
BigInt
.Did a couple other small fixes like a typo, and put
getBestBlockHeader
all inside aFuture
so any errors thrown should propagate up