Batch add filters to database #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christewart
requested changes
Jul 30, 2020
There was a problem hiding this comment.
I don't think this solves the problem. createAll is effectively a batching operation, it is just a batch size of 1. In #1724 it indicates there is 1000 queued tasks (batches) at the database level. You are effectively creating more tasks (batches) with this PR.
Oh, I see, misunderstood the problem. |
benthecarman
force-pushed
the
batch-filters
branch
from
6f67847
to
36175b9
Compare
|
Okay, changed it from adding each filter individually while syncing to add them in batches, like our callbacks |
benthecarman
force-pushed
the
batch-filters
branch
from
e2b2767
to
5633081
Compare
benthecarman
changed the title
Christewart
approved these changes
Jul 31, 2020
benthecarman
force-pushed
the
batch-filters
branch
from
5633081
to
5d0f88e
Compare
rorp
approved these changes
Aug 3, 2020
benthecarman
force-pushed
the
batch-filters
branch
from
100b145
to
df9e34d
Compare
|
Converted the variables to |
Christewart
pushed a commit
that referenced
this pull request
May 1, 2021
* Process filter headers in batch * Use correct batch * Cache filter heights * Convert to option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1724
Show now batch the the adding new filters to the db.