Implement basic TLV functionality #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkohen
changed the title
benthecarman
requested changes
Aug 18, 2020
| import scodec.bits.ByteVector | ||
|
|
||
| sealed trait TLV extends NetworkElement { | ||
| def tpe: BigSizeUInt |
There was a problem hiding this comment.
reserved word, in scala the convention is to use tpe for this reason
|
|
||
| def forIgnored(ignored: ByteVector): PongTLV = { | ||
| new PongTLV(ignored) | ||
| } |
There was a problem hiding this comment.
Are there more types we should define?
There was a problem hiding this comment.
Do you mean for TLV? We can certainly add more later but these are more or less just to test things out and define conventions.
benthecarman
approved these changes
Aug 18, 2020
Christewart
reviewed
Aug 19, 2020
Christewart
pushed a commit
that referenced
this pull request
May 1, 2021
* Defined BigSizeUInt as in BOLT 1 * Introduced UInt16 and TLV types * Responded to review * Responded to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced basic TLV types (Ping, Pong, Error, Unknown)