Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020 10 12 issue 2164 #2173

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Conversation

Christewart
Copy link
Contributor

Fixes #2164

This makes the flyway config accessible outside of DbManagement.migrate().

This PR also adds a new method, DbManagement.info() which is just a proxy for flyway.info()

@Christewart Christewart added the database database related work for our various projects label Oct 12, 2020
@Christewart Christewart added this to the v0.5.0 milestone Oct 12, 2020
@Christewart
Copy link
Contributor Author

Christewart commented Oct 13, 2020

It seems that flyway.info() does not return the same "initial" results for a database. When running postgres the very first migration i see is

<< Flyway Schema Creation >>

whereas if I run on sqlite it is the first migration we have in our repo, for instance with chaindb it is

chain db baseline

So I have to add a +1 for asserting on the size of postgres migrations as show here:

4400da4#diff-0109b6d92190e19b0c7b505e73720424e816733dfcd8663b8daee91ebc4f2a94R64

@Christewart Christewart merged commit ca5324c into bitcoin-s:master Oct 13, 2020
Christewart added a commit that referenced this pull request May 1, 2021
* Make private lazy val representing Flyway config in DbManagement, expose DbManagement.info() method

* Add more asserts based on new DbManagement.info() method

* Add extra +1 for flyway on postgres as it seems to apply an implicit migration needed to setup flyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database database related work for our various projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move flyway instance out of DbManagement.migrate()
2 participants