2022 05 05 OS specific jlink builds #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing stage/ directory
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #4316
This PR integrates
jlinkinto theappServerbuild. This means our wallet's rpc server will contain an embedded java runtime environment (jre) in the artifact we produce. This means an end user no longer needs to install java and manage their own java runtime.This PR also fixes bugs in #4316. Unfortunately sbt native packager requires
jlinkto be run on the platform its targetingAs a by product of this, we now have OS specific
zipfiles produced. Here is what our artifact list looks like now