BIP 174: Reformat, reorganize, and mark final #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Variable length string identifier" is not defined anywhere, and the suggestion to use "0x00" is also deeply unclear. I assumed it meant a nul-terminated string! Be explicit: you mean it must be a compact siz1\e unsigned int length, followed by that many identifier bytes, followed by a compact size unsigned int subtype, followed by optional keydata. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
achow101
force-pushed
the
reorganize-psbt
branch
4 times, most recently
from
6de8e70
to
5fdfba0
Compare
achow101
force-pushed
the
reorganize-psbt
branch
from
5fdfba0
to
51dc248
Compare
achow101
force-pushed
the
reorganize-psbt
branch
from
51dc248
to
88fb205
Compare
|
Argh, missed that this violates the length limit. Reverted that part. Please don't modify CI to bypass validity checks. |
t-bast
reviewed
Feb 10, 2021
| ===Procedure For New Fields=== | ||
|
|
||
| New fields should first be proposed on the bitcoin-dev mailing list. | ||
| If a field requires significatn description as to its usage, it should be accompanied by a separate BIP. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in most of the formatting changes from #953. Also explicitly specifies the parts for PSBT version 0 as well as sections for the process of adding new fields and PSBT versions. Lastly marks BIP 174 as final.
Although I am marking it as final, this is only really for the general format. New fields can be added, and those fields should be added to the field listing tables in BIP 174.