BIP105: Consensus based block size retargeting algorithm #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transferring from gist https://gist.github.com/btcdrak/1c3a323100a912b605b5
|
Number 105. |
btcdrak
changed the title
Choosing 8MB because currently the consensus among miners is 8MB is the largest tolerable size.
luke-jr
added a commit
that referenced
this pull request
Sep 3, 2015
BIP105: Consensus based block size retargeting algorithm
luke-jr
pushed a commit
to luke-jr/bips
that referenced
this pull request
Jan 20, 2018
Appending new fields to the end of the messages allows us to add new fields to an existing message, however it does not allow removing existing fields, e.g., dropping the pubkeys like bitcoin#187 proposes. Moving the features bitmap at the beginning of the signed payload allows this type of change in the future. Nodes verify the integrity of the message and then check whether there are any even bits they don't implement. These even bits being required features would then result in the message being discarded. In addition to what we discussed during the call I also went ahead and did the same reordering on `node_announcement`, which I think has the same issue. There is a subtle change in semantics, i.e., previously we would add channels with unknown bits to our local view, but then ignore them when computing a route. Now we no longer add them to our view, and may discard the announcement altogether, stopping the broadcast. This is safe I think since otherwise we'd be forwarding things we can only verify the signatures of, but nothing else.
luke-jr
pushed a commit
that referenced
this pull request
Jan 24, 2020
Update acknowledgements, remove authors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transferred from https://gist.github.com/btcdrak/1c3a323100a912b605b5