Clarify UTC for all time values in BIP70.

[schildbach]

No description provided.

[sipa]

I don't object to this as a clarification, but it's not really a change. Unix timestamps are always seconds since 1 jan 1970 UTC.

[petertodd]

NACK

Unix timestamps are UTC:

Unix time, or POSIX time, is a system for describing instants in time, defined as the number of seconds that have elapsed since 00:00:00 Coordinated Universal Time (UTC), Thursday, 1 January 1970,[note 1] not counting leap seconds.[note 2] It is used widely in Unix-like and many other operating systems and file formats. Due to its handling of leap seconds, it is neither a linear representation of time nor a true representation of UTC.[note 3] Unix time may be checked on most Unix systems by typing date +%s on the command line.
-http://en.wikipedia.org/wiki/Unix_time

[schildbach]

@petertodd I think it makes still sense as a clarification. The (I believe) first two users of the spec -- apart from the author himself -- got it wrong. I only implemented it correctly by accident.

[luke-jr]

I don't see how one can get this wrong. It shouldn't even be possible to get a Unix-time-like number in another timezone...?

If it's a clarification, it should be the one place inside the parenthesis.

[sipa]

Agree with @luke-jr here.

[schildbach]

Ok I moved the UTC into parenthesis.

I also rephrased the third appearence because it wasn't even mentioning unix time (just "system").

[petertodd]

Looks reasonable, ACK.

[schildbach]

s/Require/Clarify/ in commit description.

[jgarzik]

ACK

[laanwj]

ACK

Maybe what we need here is a reference to the definition of Unix time and the POSIX functions for it, no matter how strange it may sound people seem to not be aware of those (some developers implementing this spec manually implemented functions to count seconds since the epoch in local time?!).

[schildbach]

@laanwj Just a side node: As a Java dev, you never get in touch with unix time. All time values are expressed in milliseconds, or other fancy stuff like Date or Calendar objects.

[laanwj]

@schildbach Right, though currentTimeMilis() is really UNIX time but multiplied by a factor 1000. I don't think it gets confused about timezones.